Skip to content
Closed
Changes from 2 commits
Commits
Show all changes
180 commits
Select commit Hold shift + click to select a range
9aa9e80
test: fix timeout when running sequential/test-fs-watch-system-limit.js
mmmscott Oct 12, 2018
3ab4146
deps: cherry-pick b0af309 from upstream V8
addaleax Oct 10, 2018
849aa1e
lib: migrate to getOptions in loaders.js
rxiayth Oct 12, 2018
c24e963
test: improve test coverage for fs module
leomoreno Oct 12, 2018
9f7e3a4
src: reduce platform worker barrier lifetime
ofrobots Oct 11, 2018
64d65ed
test: fix `assert.strictEqual` arguments in test/parallel/test-c-ares.js
jungkumseok Oct 12, 2018
f0c5c96
repl: remove unused variable e from try catch
khalidadil Oct 12, 2018
478fe0a
test: fix order of values in test assertions
jehaines Oct 12, 2018
dee9d27
test: fix http local address test assertion
widatama Oct 12, 2018
c301518
repl: remove unused variable from try catch
mmisiarek Oct 12, 2018
0005846
test: replace assert.throws w/ common.expectsError
aeisenberg Oct 12, 2018
84b21eb
test: strictEqual correct order for http-information-processing test
ivansieder Oct 12, 2018
a239270
test: fix assert.strictEqual argument order
andy-ganchrow Oct 12, 2018
68b4637
lib: remove unused 'e' from catch
pdxmholmes Oct 12, 2018
767d4da
test: swap assert.strictEqual args to actual, expected
epeden Oct 12, 2018
657ee7b
test: fix incorrect ordering of args in assert.strictEqual()
mdaum Oct 12, 2018
1c73990
test: correct assert test
rmarkins-godaddy Oct 12, 2018
8691d8f
test: remove unused e variable in catch statement
DennyScott Oct 12, 2018
c23d250
test: fix incorrect expectation order
Oct 12, 2018
ffa2710
test: correct order for assert.strictEqual for inspector-helper test
nolanmar511 Oct 12, 2018
3989785
test: update test-cluster-worker-events to use arrow functions
Oct 12, 2018
882e022
test: mark `test-http2-session-timeout` as flake on ARM
refack Oct 13, 2018
97d60f9
test: don't write to stream if test passed successfully
mmmscott Oct 13, 2018
dbfb5d4
test: fix timeout when running sequential/test-fs-watch-system-limit.js
mmmscott Oct 12, 2018
1ffcd0c
test: don't write to stream if test passed successfully
mmmscott Oct 13, 2018
b6b41be
Merge branch 'fix-fs-watch-limit-timeout' of https://github.com/marcu…
mmmscott Oct 13, 2018
401dac3
test: fix errors in test-buffer-alloc.js
Trott Oct 13, 2018
9d1c9d7
lib: migrate from process.binding to internalBinding
madeinjam Oct 12, 2018
0f8eaa4
doc,meta: add references to outside C++ guides
refack Oct 7, 2018
39ae000
doc,meta: refresh wording in colab guide
refack Oct 6, 2018
fc0da7f
doc,meta: assign PR semantics
refack Oct 6, 2018
b22903e
worker: remove delete MessagePort.prototype.hasRef
Oct 12, 2018
cf7b5a8
test: correctly order assertion arguments
sheminusminus Oct 12, 2018
a9e6e68
test: swap actual and expected in assertions
yitongding Oct 12, 2018
e48d9aa
test: replace function with arrow function
yitongding Oct 12, 2018
7f74515
test: flip assertion arguments for make-callback/test.js
Oct 12, 2018
f569ecf
readline: assert without the use of event listener
Oct 12, 2018
ede79c4
test: swap the order arguments are passed to assert
n370 Oct 12, 2018
eeb2c8f
doc: edit BUILDING.md
Trott Oct 12, 2018
ff8db70
benchmark: add common.binding()
cjihrig Oct 12, 2018
190d146
test: inline common module boolean
ashleysimpson Oct 12, 2018
20fb64c
test: remove unused variable from catch
Oct 12, 2018
ff3c56c
test: remove unused "e" from catch in http2 test
Oct 12, 2018
8059ff2
benchmark: added a test benchmark for worker
umarov Oct 12, 2018
541367a
test: removed mustCallAsync from common and added inside testcase
quinnlangille Oct 12, 2018
20b3698
src: throw if functions used as constructors in node_crypto.cc
bmacnaughton Oct 12, 2018
c19ab56
src: change constructor behavior in stream_base-inl.h
iansu Oct 12, 2018
cb6c33e
test: fix assert.strictEqual params order
rockia Oct 12, 2018
446aadd
test: fix argument order for assert.strictEqual
inklin Oct 12, 2018
7b3f14a
tls: update try catch syntax
UNLRN Oct 12, 2018
5799f41
lib: remove an unused variable
chenyil Oct 12, 2018
fd230c1
test: removed unused variable
Oct 12, 2018
8ce99fa
src: move default assignment of async_id_ in async_wrap.h
davesters Oct 12, 2018
6783eed
test: change to arrow functions in send-bad-arguments
annatangzhao Oct 12, 2018
ea9df8b
tools: update ESLint to 5.7.0
cjihrig Oct 12, 2018
98afca9
crypto: move field initialization to class
Oct 12, 2018
8d29569
doc: wrap links in <>
ChALkeR Sep 2, 2018
4ba1ddb
doc: fix pr-url in repl.md
ChALkeR Sep 2, 2018
0311fcc
doc: use reserved domains for examples in url.md
ChALkeR Sep 2, 2018
3b1baf6
doc: fix url example to match behavior
ChALkeR Oct 10, 2018
98d1d53
test: fix assertion order
Chrn Oct 12, 2018
2a1492a
test: move tick.js from test/async-hooks to test/common
arur Oct 12, 2018
e096df3
doc: add "tick" function name and argument description
arur Oct 13, 2018
b2e133a
test: fix assertion order test-tls-server-verify
Oct 12, 2018
0399650
lib: switch to internalBinding for cjs loader
DrakiaXYZ Oct 12, 2018
d5824f8
test: fix assertion argument order
carlrc Oct 12, 2018
61f5543
test: rename process.argv[0] to process.execPath, rename ex to err
kaltepeter Oct 12, 2018
fd28995
test: fix strictEqual argument order
fastereder Oct 12, 2018
5a30621
doc: add info how to run single tests to BUILDING.md
fastereder Oct 12, 2018
661e732
test: modernizing test-dgram-listen-after-bind with arrow functions
chrisforrette Oct 12, 2018
af68c55
test: fix argument order in asserts
Oct 12, 2018
f8af209
test: use arrow functions in test-exception-handler
jennazee Oct 12, 2018
656a0ac
lib: removed unused variable
Oct 12, 2018
65e2253
test: modernized test to use arrow functions
ggoforth Oct 12, 2018
3fda986
test: reversed arguments in strictqual to reflect documentation
scabhi Oct 12, 2018
98f170f
test: update function keywords to fat arrows
RobertMonks Oct 12, 2018
ecd9bc0
test: fix ordering of assertion values
maccuaa Oct 12, 2018
90e72da
test: fix strictEqual assertion arguments
a0viedo Oct 12, 2018
008b97a
test: fix assertions args order in test/parallel/test-fs-chmod.js
milsosa Oct 12, 2018
6b3b64f
test: fix argument order in assertions
Oct 12, 2018
50572c0
test: put expected assert value in correct place
jfarseneau-wb Oct 12, 2018
0b1be75
test: modernize test-child-process-flush-stdio
Oct 12, 2018
d362004
test: properly order test assertion variables
DavidRS91 Oct 12, 2018
179c3a8
test: fixed incorrect variable order in assert.strictEqual()
MokhammadDaniyal Oct 12, 2018
c95707f
test: fix order of assert.strictEqual() args to actual, expected
joshua-belcher Oct 12, 2018
7e4cc76
lib: migrate process.binding('config') to getOptions()
jonnyk20 Oct 12, 2018
32cef50
test: swap assert argument order in test-vm-create-and-run-in-context.js
lefrog Oct 12, 2018
d5abbab
test: switch arguments of assert()
FieldOfPoppies Oct 12, 2018
495ced0
test: fix assert order in test-vm-context
lee-gray Oct 12, 2018
101812e
lib: migrate process.binding to getOptions
randy5235 Oct 12, 2018
ad6b09f
test: use the correct parameter order on assert.strictEqual()
lrdcasimir Oct 12, 2018
544d497
lib: migrate process.binding to internalBinding
surreal8 Oct 12, 2018
8f68ed9
test: fix assert.strictEqual arg order in test-tls-ecdh-multiple.js
takdeerkaur Oct 12, 2018
8c86463
test: fix assert.strictEqual() argument order
benschaaf Oct 12, 2018
3a62c06
test: fix test-dgram-pingpong assertion arg order
gendelbendel Oct 12, 2018
183838d
test: corret assertion arg order in test-regress-GH-892.js
elvisphilipn Oct 12, 2018
3b47722
test: replaced functions with arrow functions
edgarzapeka Oct 12, 2018
3d8c512
test: refactor functions to es6
M1chaelChen Oct 12, 2018
2d76dec
test: updating assertion on test so it fits the new method signature
leomoreno Oct 12, 2018
0d6f014
src: remove unused UVHandle methods
MarianneDr Oct 12, 2018
c3ebc02
test: reorder asserts arguments
frony Oct 12, 2018
2441808
src: use default initializers over settings fields on the constructor
andrewjdmccann Oct 12, 2018
a24027f
test: correct labelling of asserts errors
nofwayy Oct 12, 2018
d51d1ad
test: fix strictEqual assertion argument in test-tls-ecdh-auto
popopome Oct 12, 2018
5ae0f11
test: fix assert.strictEqual() argument order
ssamuels0916 Oct 12, 2018
a0aa7ad
test: corrected the order of arguments in assert.strictEqual()
parisandmilo Oct 12, 2018
08b1047
test: use correct argument order for assert.strictEqual()
Oct 12, 2018
0f17c1c
test: updating assertion and expect order in test-tls-client-verify.js
Oct 12, 2018
f7a50f7
test: refactor callback functions to arrow functions
seanhealy Oct 12, 2018
5856a59
test: fix assertion argument order
carlrc Oct 12, 2018
37dfdcc
test: fix assertions argument order
KelvinLawHF1 Oct 12, 2018
810c0d9
src: use MallocedBuffer abstraction for buffers
codyhazelwood Oct 12, 2018
d83d3ed
test: swap expected and actual arguments in assert.strictEqual()
erin-bush Oct 12, 2018
446771e
test: added test for generateKeyPair
rxiayth Oct 12, 2018
3c2f9ad
test: reverse the order of assertion statement arguments in pingpong …
AllanZhengYP Oct 12, 2018
c5d0a48
test: fix assert.strictEqual() arguments order
Oct 12, 2018
0b0aeda
test: assert.strictEqual parameters ordered correctly
jdenbroeder Oct 12, 2018
9631190
test: switch strictEqual parameters - actual first before expected
chrisbautista Oct 12, 2018
83fa60b
test: fix strictEqual assertion order on readline tests
Oct 12, 2018
a5a1e9a
test: modernize test-crypto-domain
naris93 Oct 12, 2018
c0014d5
test: fix order of assert arguments in vm-new-script-this-context
Oct 12, 2018
7e2edc5
test: added async-hook benchmark
peterjreynoldsii Oct 12, 2018
f77f693
test: reverse order of args in reconnect-error assert
jackelin-herrera Oct 12, 2018
d9a1776
build: add .DS_store to .gitgnore
frony Oct 12, 2018
620c977
test: removed unused error variable in try catch
mhussa20 Oct 12, 2018
f034606
test: update strictEqual arguments order
crpahl Oct 12, 2018
ea1565e
test: removed unused variable in fs-watch-file-slow
makitoda Oct 12, 2018
ac23e65
buffer: move process.binding('buffer') to internalBinding
starkwang Aug 17, 2018
1343891
test: fix order of parameters to assert.strictEqual
jasonnutter Oct 12, 2018
c8986bb
test: fix argument order in assertions
Oct 12, 2018
c30658c
test: fix assert.strictEqual() parameter order in test-path-maklong.js
Oct 12, 2018
f87e966
test: fix assertion arguments order
seantcoyote Oct 12, 2018
93c918e
test: increased code coverage for proxySessionHandler
justin0022 Oct 12, 2018
9bf6e2e
test: reversed actual and expected values for .strictEqual()
sshakeel Oct 12, 2018
6df946c
test: add crypto.scrypt test case with different encoding
yitongding Oct 12, 2018
bc89f9b
test: fixed strictEqual arguments order
ruyadorno Oct 12, 2018
c596bcc
test: fix arguments ordering for assertions to match the docs
lirantal Oct 12, 2018
cac4909
test: augment tests for SourceTextModule
aeisenberg Oct 12, 2018
2505f05
test: fix order of arguments passed to strictEqual
eojthebrave Oct 12, 2018
552fe56
test: fix strictEqual input parameters order
AlixAng Oct 12, 2018
01d4047
test: corrected assertion arguments order
pliab Oct 12, 2018
093cf6f
test: fix strictEqual order for timers test
Oct 12, 2018
45ef905
src: add default initializer in tls_wrap
richardhoehn Oct 12, 2018
8a32a51
test: fix assert value order
EthanWeber7 Oct 12, 2018
22afe4f
test: fix parameter order of assertions
obxpete Oct 12, 2018
aee771c
test: fix assert.strictEqual() argument order
lotharthesavior Oct 12, 2018
4b7893d
test: switch order of assertion arguments
zzidante Oct 12, 2018
c56f38f
test: updated assert test values to doc standards
keeysnc Oct 12, 2018
3f7755b
test: fix assertion order
ErickWendel Oct 12, 2018
5726173
module: removed unused variable
momander Oct 12, 2018
955148a
test: correct assertion argument order
JeffMarvin Oct 12, 2018
4e82835
test: reversed 1st and 2nd arguments for assert.strictEqual()
vchoubey08 Oct 12, 2018
1fcf83a
test: fix backward assertion arguments
svassr Oct 12, 2018
fca2173
test: update assertion parameter order
seanhealy Oct 12, 2018
99c1690
test: reverse arguments in assert.strictEqual
past5 Oct 12, 2018
a039c86
test: fix parameters in test-repl.js
binaryme Oct 12, 2018
31cb297
test: fix assertions args order
milsosa Oct 12, 2018
6151040
test: re-order strictEqual paramater calls
ptichonczuk-tc Oct 12, 2018
febb765
test: fix order of assert args in client response domain test
sheminusminus Oct 12, 2018
17c35a6
src: change macro to fn
Oct 12, 2018
f781b2c
test: fix assert equal order of arguments
Oct 12, 2018
f8b1e0e
test: change order of assert.strictEquals arguments
chucktheobald Oct 12, 2018
697c3da
test: fix assert parameter order in test-https-localaddress.js
iansu Oct 12, 2018
1237c14
test: fix assert.strictEqual() argument order
Oct 12, 2018
a979443
test: assertions arguments match docs
Agheb Oct 12, 2018
b2e4cb7
test: increased code coverage for slowCases
jehaines Oct 12, 2018
561e30d
test: use smaller keys for a faster keygen test
sam-github Oct 11, 2018
1a2cf66
async_hooks: remove promise object from resource
AndreasMadsen Oct 12, 2018
74f854e
test: add test coverage for fs.truncate
christian-bromann Oct 12, 2018
c34eae5
zlib: refactor zlib internals
addaleax Sep 22, 2018
91fe7e5
src: add deprecation warning to errname()
dtoki Oct 12, 2018
b4a5ff9
test: fix strictEqual arguments order
jonathansamines Oct 12, 2018
a17077f
test: simplify test case by just writing directly to stream object
mmmscott Oct 16, 2018
9a32087
test: fix timeout when running sequential/test-fs-watch-system-limit.js
mmmscott Oct 12, 2018
860e82f
test: don't write to stream if test passed successfully
mmmscott Oct 13, 2018
77f3ae8
test: fix timeout when running sequential/test-fs-watch-system-limit.js
mmmscott Oct 12, 2018
8f9b07d
test: don't write to stream if test passed successfully
mmmscott Oct 13, 2018
8024ad9
test: don't write to stream if test passed successfully
mmmscott Oct 13, 2018
b4468d9
test: simplify test case by just writing directly to stream object
mmmscott Oct 16, 2018
7e51c77
Merge branch 'fix-fs-watch-limit-timeout' of https://github.com/marcu…
mmmscott Oct 16, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions test/sequential/test-fs-watch-system-limit.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ if (!common.enoughTestCpu)

const processes = [];
const gatherStderr = new stream.PassThrough();
const timeout = 30000;
gatherStderr.setEncoding('utf8');
gatherStderr.setMaxListeners(Infinity);

Expand All @@ -27,7 +28,6 @@ function spawnProcesses() {
proc.stderr.pipe(gatherStderr);
processes.push(proc);
}

setTimeout(() => {
if (!finished && processes.length < 200)
spawnProcesses();
Expand All @@ -36,14 +36,27 @@ function spawnProcesses() {

spawnProcesses();

setTimeout(() => {
if (!finished) {
const timeoutStream = new stream.PassThrough();
timeoutStream.write('Error: timeout');
timeoutStream.end();
timeoutStream.pipe(gatherStderr);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not call gatherStderr.write() directly?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call!


finished = true;
processes.forEach((proc) => proc.kill());

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? Shouldn’t it already be happening below?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit aggressive with the process killing since the test had left my machine with a lot of child processes, but you're right

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be good to add to process.once('exit') in case the test fails in the middle.

}
}, timeout);

let accumulated = '';
gatherStderr.on('data', common.mustCallAtLeast((chunk) => {
accumulated += chunk;
if (accumulated.includes('Error:') && !finished) {
assert(
accumulated.includes('ENOSPC: System limit for number ' +
'of file watchers reached') ||
accumulated.includes('EMFILE: '),
accumulated.includes('EMFILE: ') ||
accumulated.includes('Timeout'),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This spells Timeout with a capital T, the text above has a lowercase t, so they don’t match … is that intentional?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unintentional, thank you

accumulated);
console.log(`done after ${processes.length} processes, cleaning up`);
finished = true;
Expand Down