Revert "src: remove unused function"#18049

Closed

jasnell wants to merge 153 commits into

nodejs:v9.x-stagingfrom

jasnell:revert-d5cef718

Commits on Jan 8, 2018

src: remove unused function

cjihrig
authored and
MylesBorins
committed
stream: remove `undefined` check

addaleax
authored and
MylesBorins
committed
net: remove Socket.prototype.write

addaleax
authored and
MylesBorins
committed
doc: add C++ style comments to the style guide

Matheus Marchini
authored and
MylesBorins
committed
http: remove adapter frame from onParserExecute

bnoordhuis
authored and
MylesBorins
committed
stream: add flow and buffer properties to streams

calvinmetcalf
authored and
MylesBorins
committed
test: check socketOnDrain where needPause is false

Leko
authored and
MylesBorins
committed
test: change callback function to arrow function

skanamaru
authored and
MylesBorins
committed
test: change callback function to arrow function

you12724
authored and
MylesBorins
committed
test: change callback function to arrow function

routerman
authored and
MylesBorins
committed
src: remove unused strings from env.h

addaleax
authored and
MylesBorins
committed
src: rename `On*` -> `Emit*` for stream callbacks

addaleax
authored and
MylesBorins
committed
doc: remove extra whitespace in module docs

watson
authored and
MylesBorins
committed
doc: change eventName type annotations

aprilwebster
authored and
MylesBorins
committed
src: replace SetAccessor w/ SetAccessorProperty

jure
authored and
MylesBorins
committed
doc: change "Node.js style cb" to "error-first cb"

lossycache
authored and
MylesBorins
committed
test: coverage for emitExperimentalWarning

mithunsasidharan
authored and
MylesBorins
committed
doc: add countdown module to writing tests guide

Bamieh
authored and
MylesBorins
committed
test: update test-http-content-length to use countdown

Bamieh
authored and
MylesBorins
committed
test: Use countdown in test file

sreepurnajasti
authored and
MylesBorins
committed
stream: rm {writeable/readable}State.length

calvinmetcalf
authored and
MylesBorins
committed
test: add test for postmortem metadata validation

cjihrig
authored and
MylesBorins
committed
doc: improve documentation.md

Fishrock123
authored and
MylesBorins
committed
doc: fix fs.existsSync description

Fishrock123
authored and
MylesBorins
committed
doc: adjust TTY wording & add inter-doc links

Fishrock123
authored and
MylesBorins
committed
doc: not all example code can be run without 1:1

Fishrock123
authored and
MylesBorins
committed
doc: some fs doc improvements

jasnell
authored and
MylesBorins
committed
n-api: fix memory leak in napi_async_destroy()

alnyan
authored and
MylesBorins
committed
doc: improve release guide

evanlucas
authored and
MylesBorins
committed
doc: edit CONTRIBUTING.md preamble

Trott
authored and
MylesBorins
committed
doc: remove unused link definition

maclover7
authored and
MylesBorins
committed
doc: fix typo in child_process.md

Trott
authored and
MylesBorins
committed
doc: fix typo in README.md

starkwang
authored and
MylesBorins
committed
doc: remove duplicate the from onboarding.md

sreepurnajasti
authored and
MylesBorins
committed
src: remove nonexistent method from header file

addaleax
authored and
MylesBorins
committed
test: change callback function to arrow function

rt33
authored and
MylesBorins
committed
crypto: remove unused header in clienthello.h

danbev
authored and
MylesBorins
committed
tools: add number-isnan rule

maclover7
authored and
MylesBorins
committed
http2: simplify onSelectPadding

addaleax
authored and
MylesBorins
committed
console: make error handling engine agnostic

BridgeAR
authored and
MylesBorins
committed
console: make variables and checks stricter

BridgeAR
authored and
MylesBorins
committed
benchmark: refactor console benchmark

BridgeAR
authored and
MylesBorins
committed
console: order functions and remove \n\n

BridgeAR
authored and
MylesBorins
committed
doc: remove old console note

BridgeAR
authored and
MylesBorins
committed
src: remove unused async hooks methods

addaleax
authored and
MylesBorins
committed
crypto: reuse variable instead of reevaluation

tniessen
authored and
MylesBorins
committed
test: fix typo in test-inspector-cluster-port-clash.js

Trott
authored and
MylesBorins
committed
net: remove ADDRCONFIG DNS hint on Windows

bzoz
authored and
MylesBorins
committed
test: increase pbkdf2 test coverage

Leko
authored and
MylesBorins
committed
repl: show lexically scoped vars in tab completion

targos
authored and
MylesBorins
committed
test: increase diffie-hellman test coverage

Leko
authored and
MylesBorins
committed
test: refactor test-net-connect-buffer

addaleax
authored and
MylesBorins
committed
doc: improve fs api descriptions

evanlucas
authored and
MylesBorins
committed
doc: instructions on how to make membership public

mhdawson
authored and
MylesBorins
committed
src: remove redundant `JSStream::DoAfterWrite`

addaleax
authored and
MylesBorins
committed
test: refactor test-repl-definecommand

Trott
authored and
MylesBorins
committed
test: improve flaky test-listen-fd-ebadf.js

Trott
authored and
MylesBorins
committed
tls: comment about old-style errors

Xavier-J-Ortiz
authored and
MylesBorins
committed
doc: improve module.builtinModules documentation

watson
authored and
MylesBorins
committed
test: use valid authentication tag length

tniessen
authored and
MylesBorins
committed
crypto: warn on invalid authentication tag length

tniessen
authored and
MylesBorins
committed
doc: removed extra explanation in api/buffer.md

WaleedAshraf
authored and
MylesBorins
committed
test: do not open fixture files for writing

Trott
authored and
MylesBorins
committed
deps: V8: cherry-pick ac0fe8ec from upstream

ofrobots
authored and
MylesBorins
committed
tools: fix man pages linking regex

DiegoRBaquero
authored and
MylesBorins
committed
test: do not open fixture files for writing

Trott
authored and
MylesBorins
committed
vm: allow modifying context name in inspector

TimothyGu
authored and
MylesBorins
committed
doc: use american spelling as per style guide

sreepurnajasti
authored and
MylesBorins
committed
doc: require CI status indicator in PRs

seishun
authored and
MylesBorins
committed
doc: mark DEP0002 as end of life

maclover7
authored and
MylesBorins
committed
lib, src: use process.config instead of regex

maclover7
authored and
MylesBorins
committed
test: use common module API in test-child-process-exec-stdout-stderr-data-string

sreepurnajasti
authored and
MylesBorins
committed
doc: add starkwang to collaborators

starkwang
authored and
MylesBorins
committed
benchmark: make temp file path configurable

Trott
authored and
MylesBorins
committed
module: print better message on esm import error

targos
authored and
MylesBorins
committed
test: fix flaky test-benchmark-fs

Trott
authored and
MylesBorins
committed
async_hooks: use CHECK instead of throwing error

maclover7
authored and
MylesBorins
committed
test: fix unreliable async-hooks/test-signalwrap

Trott
authored and
MylesBorins
committed
test: remove ambiguous error messages from test_error

nadrane
authored and
MylesBorins
committed
test: remove undefined function

Trott
authored and
MylesBorins
committed
tools: autofixer for lowercase-name-for-primitive

shobhitchittora
authored and
MylesBorins
committed
doc: update AUTHORS list

BridgeAR
authored and
MylesBorins
committed
doc: update formatting to fit our 80 chars rule

BridgeAR
authored and
MylesBorins
committed
doc: use consistent new lines

BridgeAR
authored and
MylesBorins
committed
doc: use dashes instead of asterisks

BridgeAR
authored and
MylesBorins
committed
test: reduce scope of variable in common module

Trott
authored and
MylesBorins
committed
inspector: make Coverity happy

Eugene Ostroukhov
authored and
MylesBorins
committed
tools: fix AttributeError: __exit__ on Python 2.6

dkasyanov
authored and
MylesBorins
committed
http: add rawPacket in err of `clientError` event

XadillaX
authored and
MylesBorins
committed
perf_hooks: refactor internals

jasnell
authored and
MylesBorins
committed
tls: fix SNICallback without .server option

addaleax
authored and
MylesBorins
committed
test: refactor test-tls-securepair-fiftharg

addaleax
authored and
MylesBorins
committed
crypto: add ocsp_request ClientHelloParser::Reset

danbev
authored and
MylesBorins
committed
buffer: optimize readDouble and readFloat methods

bnoordhuis
authored and
MylesBorins
committed
test: make test-tls-invoke-queued use public API

addaleax
authored and
MylesBorins
committed
doc: improve module.builtinModules text

Trott
authored and
MylesBorins
committed
doc: use my legal name in README

TimothyGu
authored and
MylesBorins
committed
test: fix flaky test-benchmark-fs

Trott
authored and
MylesBorins
committed
doc: fix typo

tniessen
authored and
MylesBorins
committed
doc: fs doc improvements

jasnell
authored and
MylesBorins
committed
readline: refactor filter() callback

Trott
authored and
MylesBorins
committed
test: replace map() with forEach() where appropriate

Trott
authored and
MylesBorins
committed
tools: enable array-callback-return ESLint rule

Trott
authored and
MylesBorins
committed
doc: doc imitating the old behavior of http.Server.keepAliveTimeout

TysonAndre-tmg
authored and
MylesBorins
committed
repl: fix coloring of `process.versions`

bnoordhuis
authored and
MylesBorins
committed
test: improve to use template string

sreepurnajasti
authored and
MylesBorins
committed
http: convert utcDate to use setTimeout

Fishrock123
authored and
MylesBorins
committed
tools: add check for using process.binding crypto

danbev
authored and
MylesBorins
committed
test: add hasCrypto when using binding('crypto')

danbev
authored and
MylesBorins
committed
test: fix repl-tab-complete --without-ssl

danbev
authored and
MylesBorins
committed
test: use countdown in test file

sreepurnajasti
authored and
MylesBorins
committed
deps: update nghttp2 to 1.29.0

jasnell
authored and
MylesBorins
committed
timers: remove domain enter and exit

apapirovski
authored and
MylesBorins
committed
gitignore: ignore *.VC.db files

tniessen
authored and
MylesBorins
committed
doc: fix duplicate words & spellings in docs

sreepurnajasti
authored and
MylesBorins
committed
test: improve readability of some crypto tests

tniessen
authored and
MylesBorins
committed
doc: remove duplicate words in API docs

tniessen
authored and
MylesBorins
committed
doc: replace wrong U+00A0 by common spaces

vsemozhetbyt
authored and
MylesBorins
committed
doc: add references to PR communication articles

Salame William
authored and
MylesBorins
committed
http2: strictly limit number on concurrent streams

jasnell
authored and
MylesBorins
committed
doc: fix spelling of contributors

Trott
authored and
MylesBorins
committed
doc: improve alt text

Trott
authored and
MylesBorins
committed
doc: copy-edit COLLABORATOR_GUIDE.md

Trott
authored and
MylesBorins
committed
build: remove duplicate async-hooks and known_issues test runs

Trott
authored and
MylesBorins
committed
doc: remove non-style information from style guide

Trott
authored and
MylesBorins
committed
doc: fix typos in CONTRIBUTING.md

Trott
authored and
MylesBorins
committed
doc: improve PR-review paragraph in CONTRIBUTING.md

Trott
authored and
MylesBorins
committed
doc: remove x86 from os.arch() options

gibfahn
authored and
MylesBorins
committed
doc: edit for concision

Trott
authored and
MylesBorins
committed
doc: improve security section of README.md

Trott
authored and
MylesBorins
committed
src: remove unused GetHostByNameWrap

bnoordhuis
authored and
MylesBorins
committed
src: inline HostentToAddresses()

bnoordhuis
authored and
MylesBorins
committed
doc: move joshgav to TSC emeriti list

Trott
authored and
MylesBorins
committed
benchmark: fix timeout in write-stream-throughput

apapirovski
authored and
MylesBorins
committed
test: fix flaky test-resolve-async

apapirovski
authored and
MylesBorins
committed
test: simplify test-buffer-slice.js

starkwang
authored and
MylesBorins
committed
test: fix crypto test case to use correct encoding

tniessen
authored and
MylesBorins
committed
test: fix flaky http-writable-true-after-close

apapirovski
authored and
MylesBorins
committed
test: fix flaky test-pipe-unref

apapirovski
authored and
MylesBorins
committed
http: remove duplicate export

evanlucas
authored and
MylesBorins
committed
test: fix flaky test-http-highwatermark

apapirovski
authored and
MylesBorins
committed
test: rename regression tests

tniessen
authored and
MylesBorins
committed
cluster: support windowsHide option for workers

toddwong
authored and
MylesBorins
committed
tools: host remark-preset-lint-node in-tree

maclover7
authored and
MylesBorins
committed
build: put .PHONY directly before its target

Oky Antoro
authored and
MylesBorins
committed
http2: verify that a dependency cycle may exist

jasnell
authored and
MylesBorins
committed
test: fix common.expectsError

refack
authored and
MylesBorins
committed
test: add more asserts to `test-internal-errors`

refack
authored and
MylesBorins
committed
test: fix flaky test-http-pipeline-flood

apapirovski
authored and
MylesBorins
committed
doc: move matthewloring to emeriti

Trott
authored and
MylesBorins
committed
doc: updates examples to use NULL

mhdawson
authored and
MylesBorins
committed
lib: remove queue implementation from JSStreamWrap

addaleax
authored and
MylesBorins
committed

Commits on Jan 9, 2018

Revert "src: remove unused function"
jasnell
committed

Uh oh!

Commits

Commits on Jan 8, 2018