26.0.0 fails to build on NetBSD: missing include

[moubctez]

Version

26.0.0

Platform

NetBSD virtual 11.99.6 NetBSD 11.99.6 (GENERIC64) #0: Mon May  4 09:49:31 CEST 2026

Subsystem

No response

What steps will reproduce the bug?

Build NodeJS 26.0.0 on NetBSD

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

Build proceeds

What do you see instead?

Build fails with:

../deps/v8/src/base/memcopy.h: In function 'void v8::base::SimdMemCopy(void*, const void*, size_t)':
../deps/v8/src/base/memcopy.h:57:23: error: 'CHAR_BIT' was not declared in this scope
   57 |       sizeof(count) * CHAR_BIT - bits::CountLeadingZeros(count - 1);
      |                       ^~~~~~~~
../deps/v8/src/base/memcopy.h:21:1: note: 'CHAR_BIT' is defined in header '<climits>'; this is probably fixable by adding '#include <climits>'

Additional information

Fix:

--- deps/v8/src/base/memcopy.h.orig	2026-05-06 07:22:58.678410124 +0000
+++ deps/v8/src/base/memcopy.h
@@ -5,6 +5,7 @@
 #ifndef V8_BASE_MEMCOPY_H_
 #define V8_BASE_MEMCOPY_H_
 
+#include <climits>
 #include <stdlib.h>
 
 #include <atomic>

[bschnei]

If helpful, I believe this is related to building with GCC 16. I believe in earlier GCC versions, including <vector> or <algorithm> would transitively include <climits>. With 16, if a file uses CHAR_BIT, it must now explicitly #include <climits>.

[tjuhaszrh]

The same failure is also present when building with clang on aarch64 architecture.

[Renegade334]

Didn't look like anyone had opened an upstream issue yet.

https://issues.chromium.org/issues/512749476