`wasi` incorrectly defined on global

[nomagick]

Version

v18.12.1

Platform

Linux - 5.4.190-107.353.amzn2.x86_6

Subsystem

wasi global

What steps will reproduce the bug?

global.wasi

Object.getOwnPropertyNames(global).forEach((k) => {
    const v = Reflect.get(global, k);
    if (isConstructor(v)) {
        NATIVE_CLASS_PROTOTYPES.set(v.prototype, v);
    }
});

Uncaught Error: Cannot find module 'wasi'

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

global.wasi evaluates to undefined;

assert(global.hasOwnProperty('wasi') === false)

What do you see instead?

Uncaught Error: Cannot find module 'wasi' for global.wasi

assert(global.hasOwnProperty('wasi') === true)

Additional information

--experimental-wasi-unstable-preview1 not specified

[cjihrig]

I'm not sure exactly what you're reporting here. The wasi module is only available if you start Node with --experimental-wasi-unstable-preview1, and even then it won't be a global.

[nomagick]

@cjihrig I mean even if I didn't start node with --experimental-wasi-unstable-preview1, it's still defined on global.
It's defined but triggers error when you try to read from it.
So I suppose that's a bug.

[cjihrig]

Is this in the REPL only?

[nomagick]

Oh yes in repl only, sorry.
Not that much of a bug then.

[cjihrig]

I'm going to reopen. Even though it's just in the REPL, we should fix this.

[cola119]

#39911 (released in v16.10.0) fixed not to load wasi module when the flag is not set, but wasi property is still defined on global.