Skip to content

Remove circular dependency in code cache and snapshot buildingΒ #31074

@joyeecheung

Description

@joyeecheung

This issue tracks this TODO in node.gyp (which was originally for the code cache builder, but we also need something similar for the snapshot builder)

node/node.gyp

Lines 1176 to 1181 in db109e8

# TODO(joyeecheung): do not depend on node_lib,
# instead create a smaller static library node_lib_base that does
# just enough for node_native_module.cc and the cache builder to
# compile without compiling the generated code cache C++ file.
# So generate_code_cache -> mkcodecache -> node_lib_base,
# node_lib -> node_lib_base & generate_code_cache

Removing the current circular dependency in the two-step builds should make this building process less error-prone.

Previous refs:

#27431
#30647

Metadata

Metadata

Assignees

Labels

buildIssues and PRs related to build files or the CI.

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions