-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
fs: make rmdir() emfileWait handle ENFILE #30482
Copy link
Copy link
Closed
Labels
fsIssues and PRs related to the fs subsystem / file system.Issues and PRs related to the fs subsystem / file system.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.
Metadata
Metadata
Assignees
Labels
fsIssues and PRs related to the fs subsystem / file system.Issues and PRs related to the fs subsystem / file system.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.
Type
Fields
Give feedbackNo fields configured for issues without a type.
EMFILE: current process is out of file descriptorsENFILE: system is out of file descriptorsThe
fs.rmdir()logic inlib/internal/fs/rimraf.jscurrently handles the former but not the latter:node/lib/internal/fs/rimraf.js
Lines 43 to 44 in ed40123
Both are (hopefully) transient errors though and should be handled identically.
Since
ENFILEis difficult to test for, I think it's okay to omit a regression test.