require.resolve() fails with an empty options object

[75lb]

• Version: v12.4.0
• Platform: macOS 10.14.5
• Subsystem: module

In an empty directory, install lodash then from the REPL run the following commands. The second command fails if you pass an empty options object.

> require.resolve('lodash')
'/Users/lloyd/Documents/tmp/require-resolve/node_modules/lodash/lodash.js'

> require.resolve('lodash', {})
Thrown:
Error: Cannot find module 'lodash'
Require stack:
- <repl>
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:623:15)
    at Function.resolve (internal/modules/cjs/helpers.js:21:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '<repl>' ]
}

If the options value is {} or { paths: undefined } I would expect it to be ignored and the built-in defaults used.

This issue breaks a few of my apps in node >= 12.3.

[cjihrig]

This should be the fix:

diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js
index 5cb88da189..98cfe02a97 100644
--- a/lib/internal/modules/cjs/loader.js
+++ b/lib/internal/modules/cjs/loader.js
@@ -601,10 +601,11 @@ Module._resolveFilename = function(request, parent, isMain, options) {
     } else if (options.paths !== undefined) {
       throw new ERR_INVALID_OPT_VALUE('options.paths', options.paths);
     }
-  } else {
-    paths = Module._resolveLookupPaths(request, parent);
   }
 
+  if (paths === undefined)
+    paths = Module._resolveLookupPaths(request, parent);
+
   // Look up the filename first, since that's the cache key.
   const filename = Module._findPath(request, paths, isMain);
   if (!filename) {

PR coming.