HTTP GET Request with a long URI produces a 400 Bad Request error (should be 414)

[RMHonor]

• Version: v10.13.0 (docker image node:lts-alpine)
• Platform: Linux 552c097b0775 4.9.125-linuxkit deps: update openssl to 1.0.1j #1 SMP Fri Sep 7 08:20:28 UTC 2018 x86_64 Linux (docker image node:lts-alpine)

Performing a GET request with a URI too long (as specified in https://github.com/nodejs/http-parser/blob/master/http_parser.h#L55) throws a 400 Bad Request error. This should be a 414 URI Too Long.

[lpinca]

It will soon (Node.js 12) return 431 instead of a generic 400. See #25605.

The code returned is the same (HPE_HEADER_OVERFLOW) so I'm not sure if we can differentiate between 414 and 431.

[bnoordhuis]

You can distinguish between them when an on_url callback has been observed but no on_status or on_header_field callbacks. I'm inclined to say it's not worth the additional complexity though.

[jasnell]

Is there anything actionable here?

[marco-ippolito]

Fixed by #25605