http2: need a way to deal with aborted connections

[addaleax]

• Platform: various
• Subsystem: http2

The test issues in #21561 highlighted that we have an issue in HTTP/2 with dealing with aborted connections. At this point, it’s not obvious how to do so in a cross-platform manner without triggering uncaught exceptions.

This part of the test should not be necessary:

node/test/parallel/test-http2-respond-with-file-connection-abort.js

Lines 32 to 37 in d94950e

	// TODO(addaleax): This is a *hack*. HTTP/2 needs to have a proper way of
	// dealing with this kind of issue.
	process.once('uncaughtException', (err) => {
	if (err.code === 'ECONNRESET') return;
	throw err;
	});

/cc @nodejs/http2 @apapirovski

[mcollina]

I think it should be emitted by the server’s stream. Isn’t it? Can you attach a full stacktrace?

Is this causing problems on Windows?

[addaleax]

I think it should be emitted by the server’s stream. Isn’t it?

Yes. But how would one know that? It’s not like this is documented or necessarily logical, because network connections match HTTP/2 sessions, not HTTP/2 streams. I’ll be opening a PR with a test update + docs shortly.