Skip to content

core.h not foundΒ #20921

Description

@jdalton

I noticed using Node 10.2.0 that the sleep package now fails to build with the following error
(it didn't fail with 10.1.0):

In file included from ../src/LoopChecker.cpp:5:
In file included from ../src/LoopChecker.hpp:3:
In file included from ../../../nan/nan.h:51:
/Users/jdalton/.node-gyp/10.2.0/include/node/node.h:53:10: fatal error: 'core.h' file not found
#include "core.h"  // NOLINT(build/include_order)
         ^~~~~~~~
1 error generated.
1 error generated.
1 error generated.
make: *** [Release/obj.target/native_metrics/src/RUsageMeter.o] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Release/obj.target/native_metrics/src/GCBinder.o] Error 1
make: *** [Release/obj.target/native_metrics/src/native_metrics.o] Error 1
1 error generated.
make: *** [Release/obj.target/native_metrics/src/LoopChecker.o] Error 1

The problem line appears to be

#include "core.h" // NOLINT(build/include_order)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions