-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
potential null pointer deref? #19991
Copy link
Copy link
Closed
Labels
trace_eventsIssues and PRs related to V8, Node.js core, and userspace code trace events.Issues and PRs related to V8, Node.js core, and userspace code trace events.
Metadata
Metadata
Assignees
Labels
trace_eventsIssues and PRs related to V8, Node.js core, and userspace code trace events.Issues and PRs related to V8, Node.js core, and userspace code trace events.
We noticed these two sites as potential null pointer deferences.
node/src/node_trace_events.cc
Lines 51 to 53 in ebbf393
node/src/node_trace_events.cc
Lines 130 to 132 in ebbf393
It seems like
category_group_enabledcan be null based on the defensive check:node/src/node_trace_events.cc
Lines 19 to 23 in ebbf393
But I suspect because of the usage
GetCategoryGroupEnabledis not called with null pointer. Any thoughts?