test: More descriptive name for test file names

[dsinecos]

• Version: master
• Platform: 16.04.1, Ubuntu
• Subsystem: test

I was going through the following test files test-process-geteuid-getegid.js and test-process-setuid-setgid.js

I was wondering if the filenames could include the name of all the methods that are being tested so

• test-process-geteuid-getegid.js could be renamed to test-process-geteuid-getegid-seteuid-setegid.js
• And test-process-setuid-setgid.js could be renamed to test-process-getuid-getgid-setuid-setgid.js

I had a little confusion when locating these files and I thought maybe this change would help. Also, I read the guidelines on naming test files and it allows for listing the methods being tested and additional information where needed.

There are test files with over 60 characters eg. test-timers-socket-timeout-removes-other-socket-unref-timer.js, test-process-exception-capture-should-abort-on-uncaught-setflagsfromstring.js so I understand the renaming would not violate any character limit restrictions on test file names

If the above change isn't possible I was thinking for the sake of consistency, the test files could be renamed to test-process-getuid-getgid.js and test-process-getegid-geteuid.js. I was initially confused for a bit when I found the test-process-geteuid-getegid.js but not a corresponding test-process-getuid-getgid.js

[tniessen]

Even though there is no hard limit for the file name length, it is usually a good idea to keep them as short as reasonably possible. How about test-process-euid-egid.js and test-process-uid-gid.js?

[dsinecos]

@tniessen That makes sense, this way it keeps the file names concise and also indicates what kind of methods the file tests for

[rajdhandus]

@dsinecos @tniessen @lpinca - I would like to take this up.. Can i please work on this issue?

[lpinca]

@rajdhandus sure.

[rajdhandus]

thanks..