Investigate flaky sequential/test-async-wrap-getasyncid

[joyeecheung]

• Version: master
• Platform: windows, linux, arm(?)
• Subsystem: async_wrap

Opening a separate issue for the flake reported in #13020 (comment) , I have not seem it for a while but tonight it has come back in different unrelated PRs.

Sample:

https://ci.nodejs.org/job/node-test-commit-linux/15590/nodes=alpine37-container-x64/console
https://ci.nodejs.org/job/node-test-binary-windows/14242/COMPILED_BY=vs2017,RUNNER=win10,RUN_SUBSET=3/console

not ok 1953 sequential/test-async-wrap-getasyncid
  ---
  duration_ms: 0.356
  severity: fail
  stack: |-
    Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
        at Object.exports.mustCall (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine37-container-x64/test/common/index.js:497:10)
        at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine37-container-x64/test/sequential/test-async-wrap-getasyncid.js:19:35)
        at Module._compile (module.js:660:30)
        at Object.Module._extensions..js (module.js:671:10)
        at Module.load (module.js:577:32)
        at tryModuleLoad (module.js:517:12)
        at Function.Module._load (module.js:509:3)
        at Function.Module.runMain (module.js:701:10)
        at startup (bootstrap_node.js:194:16)
  ...

[tniessen]

Also here (Alpine) and here (Windows 10).

[BridgeAR]

Closing as duplicate of #13020

[joyeecheung]

@BridgeAR This issue appears after the fix of #13020 landed, see #13020 (comment) and #13020 (comment)

[joyeecheung]

@BridgeAR I'll close the original issue. Have not seen a CRASHED in this test in these two months so we probably don't need to open a separate issue for #13020 (comment)

[joyeecheung]

This is similar to #16210, both beforeExit being emitted twice

[apapirovski]

@joyeecheung I have a strong feeling this might be related to eca73a2 or 791975d — this only started failing after those commits landed and at a quick glance, the test does use node_file.cc in a number of tests.

[joyeecheung]

@apapirovski The last CI run of eca73a2 was https://ci.nodejs.org/job/node-test-pull-request/12540/, which did not contain this flake. The CI run before 791975d landed was https://ci.nodejs.org/job/node-test-pull-request/12562/ (for another PR ) and there was already this flake...still investigating before those CI runs expired