Buffer#writeFloat/writeDouble methods don't return an error code yet while the others do

[rogierschouten]

• Version: 9.4.0
• Platform: Windows 10 64-bit
• Subsystem: buffer.js

Note how the first error has the ERR_INDEX_OUT_OF_RANGE code while the second one doesn't.

$ node
> var b = new Buffer([])
undefined
> b.writeInt8(3)
RangeError [ERR_INDEX_OUT_OF_RANGE]: Index out of range
    at checkInt (buffer.js:1277:11)
    at Buffer.writeInt8 (buffer.js:1442:5)
> b.writeDoubleBE(3)
RangeError: Index out of range
    at Buffer.writeDoubleBE (buffer.js:1533:5)
>

The affected methods are the write float/double LE/BE functions. All others behave correctly.

This complicates error handling unnecessarily and I don't think this is intended behavior. Bug?

[bnoordhuis]

The floating-point write methods are implemented in C++ and no C++ code currently throws ERR_ codes.

I'm planning to reimplement them in JS. I did that for their read counterparts in #17775 to good effect and it also fixes the error code thing in one swoop.

[seishun]

I'm planning to reimplement them in JS.

Are you still planning to do it any time soon? If not, I could give it a shot.

[bnoordhuis]

@BridgeAR beat me to it, see #18395.

[apapirovski]

Think this was fixed by #18395 but didn't get auto-closed. @BridgeAR @bnoordhuis please reopen if that's incorrect or some part was missed there.

[rogierschouten]

@apapirovski I think you're right, this commit contains tests for the proper error behaviour: 63eb1fc