net.js broken in node 8.8

[felixbrucker]

• Version: v8.8.0
• Platform: Linux staging 4.10.0-37-generic #41-Ubuntu SMP Fri Oct 6 20:20:37 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
• Subsystem: net.js

I do not really have simple code, i noticed the problem while running storjshare-daemon, it happend about every 1-5 minutes:

net.js:401
  const prevWriteQueueSize = this._handle.writeQueueSize;
                                          ^

TypeError: Cannot read property 'writeQueueSize' of null
    at Socket._onTimeout (net.js:401:43)
    at ontimeout (timers.js:471:11)
    at tryOnTimeout (timers.js:306:5)
    at Timer.listOnTimeout (timers.js:266:5)

This error seems to be introduced with the recent commit: a627c5f

[addaleax]

@apapirovski

[JohanvdWest]

Got the same. The code does not take into account the fact that the socket could be closed by another error (like the other side closing it).

Needs to check if _handle is valid.

[joyeecheung]

Refs: #15791

[apapirovski]

Bah, I thought I went through all the possibilities of _handle getting unset and couldn't find a way that it would in that code. Working on a PR.

[apapirovski]

Thanks for reporting @felixbrucker and @JohanvdWest. PR is at #16489