http2 websocket

[ronag]

Since http2 does not have the upgrade event maybe the docs should mention how to combine a node http2 server with websockets?

[apapirovski]

Hi @ronag, you can't use websockets with http2. See https://daniel.haxx.se/blog/2016/06/15/no-websockets-over-http2/ for more info.

[ronag]

@apapirovski: Yes, so somehow I have to start a http1 server on the same port? How does e.g. nginx do it to support both on the same port?

[jasnell]

http/2 does have a fallback mechanism that allows http1 and http2 on the same port; for right now the impl in core depends on having a TLS connection and using ALPN to differentiate. See the test case in https://github.com/nodejs/node/blob/master/test/parallel/test-http2-https-fallback.js

It's a bit rough still. We're still working through the details of this particular bit.

[ronag]

@jasnell: Thanks! Where can I follow your progress?

[jasnell]

This repo is the best place. It's a bit difficult to follow at times, but if you track the PRs labeled http2 it should be fairly straightforward to follow along.

[ronag]

Would something like this work?

  // Check for websocket path
  if (headers[':path'].startsWith('/deepstream')) {
    const socket = net.connect(ds.port, ds.hostname, () => {
      stream.respond();
      socket.pipe(stream);
      stream.pipe(socket);
    })
  }

[jasnell]

It should, yes.

[jasnell]

wait... sorry, I got your threads mixed up... this should work for proxying in general, but not for websockets. There is no way to implement websockets on the same connection as http2

[ronag]

@jasnell: It would be nice to be able to have request listener that only receives the HTTP1 requests with no HTTP2 compat. I am handling HTTP2 in stream handler and the compat request instances are just wasted.

[damianobarbati]

WOW. That's crazy: so today you have to choose whether use "http2" OR "websockets" with node?

[jasnell]

There is a draft spec for using websockets with http2 but none of the existing implementations support it yet.

[damianobarbati]

Thanks @jasnell, are you referring to this? https://tools.ietf.org/html/draft-ietf-httpbis-h2-websockets-00
It says:

This Internet-Draft will expire on June 22, 2018.

I'm pretty ignorant here, what's going to happen on June 22 this year?