Skip to content

tracing: unsafe Agent::Stop() call in signal handler #14802

@bnoordhuis

Description

@bnoordhuis

Commit ba4847e introduces a call to tracing::Agent::Stop() in the SignalExit() function.

Signal handlers are only allowed to call async-signal-safe functions, which the implementation of tracing::Agent::Stop() is not. This can cause erratic behavior; crashes, hangs, etc.

@jasongin @matthewloring

Metadata

Metadata

Assignees

No one assigned

    Labels

    trace_eventsIssues and PRs related to V8, Node.js core, and userspace code trace events.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions