Skip to content

"Landing Pull Requests" is incompatible with repo setup in CONTRIBUTING.mdΒ #13600

@seishun

Description

@seishun

The "Technical HOWTO" section in COLLABORATOR_GUIDE.md "assumes your repo is set up as detailed in CONTRIBUTING.md".

However, the "Step 1: Fork" section in CONTRIBUTING.md suggests setting up upstream as git://github.com/nodejs/node.git. When trying to push to it, git returns the following error:

fatal: remote error:
  You can't push to git://github.com/nodejs/node.git
  Use https://github.com/nodejs/node.git

Is there a particular reason why CONTRIBUTING.md uses a git:// link? Can we just replace that with git@github.com:nodejs/node.git?

Metadata

Metadata

Assignees

No one assigned

    Labels

    docIssues and PRs related to the documentations.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions