-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
investigate flaky sequential/test-benchmark-child-process on WindowsΒ #12560
Copy link
Copy link
Closed
Labels
benchmarkIssues and PRs related to the benchmark subsystem.Issues and PRs related to the benchmark subsystem.child_processIssues and PRs related to the child_process subsystem.Issues and PRs related to the child_process subsystem.testIssues and PRs related to the tests.Issues and PRs related to the tests.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Metadata
Metadata
Assignees
Labels
benchmarkIssues and PRs related to the benchmark subsystem.Issues and PRs related to the benchmark subsystem.child_processIssues and PRs related to the child_process subsystem.Issues and PRs related to the child_process subsystem.testIssues and PRs related to the tests.Issues and PRs related to the tests.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
sequential/test-benchmark-child-processis still failing sometimes flaky on Windows in CI. I'll open a PR to mark it as flaky. This issue is for trying to locate the problem and a solution.When the test succeeds, it seems to take just a few seconds.
https://ci.nodejs.org/job/node-test-binary-windows/RUN_SUBSET=3,VS_VERSION=vs2015,label=win2008r2/7865/console
When it fails, it's a timeout.
https://ci.nodejs.org/job/node-test-binary-windows/7867/RUN_SUBSET=3,VS_VERSION=vs2015,label=win2008r2/console
This would suggest a race condition or something else causing a child process to hang or something. And that might be the cause. But...
Interestingly, a stress test where the five benchmarks that this test calls were all split out into individual tests, succeeded but each test took around 30 seconds to run. Wha??!! I know! (Only other change in those tests is the
duroption for the benchmarks was increased from 0 to 0.1. Well, that, and that this test was run on win2016 so maybe the results are completely irrelevant? I don't know.)https://ci.nodejs.org/job/node-stress-single-test/1161/nodes=win2016/console:
So I'm not sure what's going on here. Maybe it can be worked out by someone more comfortable testing and debugging on Windows or someone more deeply familiar with child_process and/or our benchmarking code. @nodejs/platform-windows @nodejs/benchmarking @mscdex @cjihrig @bnoordhuis @nodejs/testing