-
-
Notifications
You must be signed in to change notification settings - Fork 35.7k
test the benchmarks at one iterationΒ #12068
Copy link
Copy link
Closed
Labels
benchmarkIssues and PRs related to the benchmark subsystem.Issues and PRs related to the benchmark subsystem.testIssues and PRs related to the tests.Issues and PRs related to the tests.
Metadata
Metadata
Assignees
Labels
benchmarkIssues and PRs related to the benchmark subsystem.Issues and PRs related to the benchmark subsystem.testIssues and PRs related to the tests.Issues and PRs related to the tests.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Of course we don't want to "actually" run the benchmarks during a test run. However, the benchmark runner already is able to set how many iterations the benchmarks run, and we could probably extend that even more.
As such, I don't see much reason to not run most of the benchmarks during a normal test run, with e.g. only one iteration set.
Or, at the very least perhaps we could have some sort of special CI job that does that, to be run, say, weekly.
cc @nodejs/testing @nodejs/benchmarking