In async function, returns a value in try block will before await statement in finally block

[zbinlin]

• Version: 7.7.3
• Platform: Arch Linux

Testcase:

async function test() {
    try {
        console.log("1");
        return await Promise.resolve();
    } finally {
        console.log("2");
        await Promise.resolve();
        console.log("3");
    }
}

test().then(() => {
    console.log("4");
});

Expected:

1
2
3
4

Actual:

1
2
4
3

[targos]

Thanks for the report.
This looks like a V8 bug and it is fixed in Canary. I'll try to bisect.

[targos]

This was fixed in v8/v8@39642fa

/cc @nodejs/v8 can we safely backport this commit to Node 7 (V8 5.5) and/or V8 5.7 ?

[bnoordhuis]

I don't know, you'd have to try. 5.7 should be an easier target than 5.5. If a full back-port is too onerous, you might be able to get away with dropping the ignition (interpreter) changes.

[targos]

It seems to work fine on 5.7. I added the backport to #11752

[targos]

I attempted a backport (without looking in depth at the changes; just applied the patch and fixed conflicts) to v7.x-staging in targos@46b0159. It compiles and the Node.js test suite passes but the OP's testcase only prints

1
2
3

[gsathya]

You need the ignition changes for this to work. Can you try merging https://codereview.chromium.org/2672313003/ to 5.5? This is a fix in the parser, instead of ignition. This might be easier to merge.

[targos]

Thank you @gsathya. It's indeed easier to merge. I backported https://codereview.chromium.org/2633353002 with it.
I will do some testing and open a PR tomorrow.

[targos]

#12004