Skip to content

https: certificate validation fails when using servername optionΒ #1106

@skenqbx

Description

@skenqbx

Agent#createSocket() overwrites options.servername leading to a tls.checkServerIdentity() against hostname instead of servername.

I usually disabled connection pooling in that case, but that is not possible anymore as ClientRequest#constructor always sets an agent.

Not sure if this is intentional; Did I overlook something in the changelog?

Metadata

Metadata

Assignees

No one assigned

    Labels

    confirmed-bugIssues with confirmed bugs.httpsIssues or PRs related to the https subsystem.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions