Exit code non zero

[BridgeAR]

I think it would be nice if the call would return a non-zero exit code in case a requirement is missing.

[priyank-p]

Sure, do you want to make a PR it just adding non-zero exit if status is false.

[ryzokuken]

@BridgeAR @cPhost I'd love to have a shot at this one, I'd just need a little more detail regarding what exactly needs to be done.

[joyeecheung]

I think this has been fixed now? AFAICT, the commands are using runPromise to run things and that exits with 1 in .catch (which reminded me there seem to be another bug...all the .catch we have been attaching to runPromise or runAsync calls will not be called because of that, but they all seem to work fine even without those handlers run..)

[ryzokuken]

@joyeecheung If you're positive about it, please proceed to close this issue. Also, let me know if you think the redundant .catch calls should be removed, and I'll look into it.

[priyank-p]

This is still not fixed yet, all that needs to be done is, add a then to getMetadata and if the status if false exit with non-zero exit code.

[ryzokuken]

@cPhost isn't get-metadata deprecated?