Skip to content

feat: support building shared libraries on z/OS - #137

Merged
targos merged 2 commits into
nodejs:mainfrom
ibmruntimes:up_supportsharedlib_zos
Apr 4, 2022
Merged

feat: support building shared libraries on z/OS#137
targos merged 2 commits into
nodejs:mainfrom
ibmruntimes:up_supportsharedlib_zos

Conversation

@alexcfyung

Copy link
Copy Markdown
Contributor

Allow gyp to build shared libraries such as .x file on z/OS. This is needed to enable node.js to build shared library on z/OS.

@AdNaN-rK AdNaN-rK left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AdNaN-rK AdNaN-rK left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reqes change

@AdNaN-rK AdNaN-rK left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@AdNaN-rK AdNaN-rK left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review changes

@AdNaN-rK AdNaN-rK left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review changes

@AdNaN-rK AdNaN-rK left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes

@zsw007

zsw007 commented Mar 28, 2022

Copy link
Copy Markdown

Request changes

Hi, could you please clarify what changes are requested?

@ryzokuken ryzokuken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM, someone please merge if this works as intended.

@targos
targos merged commit 293bcfa into nodejs:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants