Skip to content

fix(store): use isObservable to test whether actions return an observable - #1925

Merged
markwhitfeld merged 2 commits into
masterfrom
fix/1921
Oct 17, 2022
Merged

fix(store): use isObservable to test whether actions return an observable#1925
markwhitfeld merged 2 commits into
masterfrom
fix/1921

Conversation

@arturovt

@arturovt arturovt commented Oct 16, 2022

Copy link
Copy Markdown
Member

Issue: #1921

We can safely use isObservable since it already does instanceof Observable, but also checks for obj.lift && obj.subscribe to be functions.

@qlty-cloud-legacy

qlty-cloud-legacy Bot commented Oct 16, 2022

Copy link
Copy Markdown

Code Climate has analyzed commit 110bad1 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@bundlemon

bundlemon Bot commented Oct 16, 2022 •
edited
Loading

Copy link
Copy Markdown

BundleMon

Unchanged files (6)
Status Path Size Limits
✅ fesm5/ngxs-store.js
 133.1KB 145KB / +0.5%
✅ fesm2015/ngxs-store.js
 114.15KB 125KB / +0.5%
✅ fesm5/ngxs-store-operators.js
 10.07KB 15KB / +0.5%
✅ fesm2015/ngxs-store-operators.js
 9.94KB 15KB / +0.5%
✅ fesm5/ngxs-store-internals.js
 6.58KB 20KB / +0.5%
✅ fesm2015/ngxs-store-internals.js
 5.65KB 20KB / +0.5%

Total files change -4B 0%

Groups updated (2)
Status Path Size Limits
✅ @ngxs/store(esm2015)[gzip]
./esm2015/**/*.js
 167.95KB (+132B +0.08%) +1%
✅ @ngxs/store(esm5)[gzip]
./esm5/**/*.js
 174.47KB (+123B +0.07%) +1%
Unchanged groups (4)
Status Path Size Limits
✅ @ngxs/store(umd)[gzip]
./bundles/*.umd.js
 39.34KB +1%
✅ @ngxs/store(fesm5)[gzip]
./fesm5/*.js
 28.74KB +1%
✅ @ngxs/store(fesm2015)[gzip]
./fesm2015/*.js
 26.37KB +1%
✅ @ngxs/store(umd.min)[gzip]
./bundles/*.umd.min.js
 13.45KB +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon

bundlemon Bot commented Oct 16, 2022 •
edited
Loading

Copy link
Copy Markdown

BundleMon (NGXS Plugins)

Unchanged files (28)
Status Path Size Limits
✅ Plugins(umd)[gzip]
storage-plugin/bundles/ngxs-storage-plugin.um
d.js
 7.24KB +1%
✅ Plugins(umd)[gzip]
hmr-plugin/bundles/ngxs-hmr-plugin.umd.js
 6.96KB +1%
✅ Plugins(umd)[gzip]
websocket-plugin/bundles/ngxs-websocket-plugi
n.umd.js
 6.87KB +1%
✅ Plugins(umd)[gzip]
router-plugin/bundles/ngxs-router-plugin.umd.
js
 6.5KB +1%
✅ Plugins(umd)[gzip]
form-plugin/bundles/ngxs-form-plugin.umd.js
 6.44KB +1%
✅ Plugins(umd)[gzip]
devtools-plugin/bundles/ngxs-devtools-plugin.
umd.js
 6.16KB +1%
✅ Plugins(umd)[gzip]
logger-plugin/bundles/ngxs-logger-plugin.umd.
js
 5.77KB +1%
✅ Plugins(fesm5)[gzip]
storage-plugin/fesm5/ngxs-storage-plugin.js
 3.95KB +1%
✅ Plugins(fesm2015)[gzip]
storage-plugin/fesm2015/ngxs-storage-plugin.j
s
 3.64KB +1%
✅ Plugins(fesm5)[gzip]
hmr-plugin/fesm5/ngxs-hmr-plugin.js
 3.62KB +1%
✅ Plugins(fesm5)[gzip]
websocket-plugin/fesm5/ngxs-websocket-plugin.
js
 3.53KB +1%
✅ Plugins(fesm2015)[gzip]
hmr-plugin/fesm2015/ngxs-hmr-plugin.js
 3.25KB +1%
✅ Plugins(fesm5)[gzip]
router-plugin/fesm5/ngxs-router-plugin.js
 3.15KB +1%
✅ Plugins(fesm2015)[gzip]
websocket-plugin/fesm2015/ngxs-websocket-plug
in.js
 3.15KB +1%
✅ Plugins(umd.min)[gzip]
hmr-plugin/bundles/ngxs-hmr-plugin.umd.min.js
 3.1KB +1%
✅ Plugins(fesm5)[gzip]
form-plugin/fesm5/ngxs-form-plugin.js
 3.07KB +1%
✅ Plugins(fesm2015)[gzip]
router-plugin/fesm2015/ngxs-router-plugin.js
 2.89KB +1%
✅ Plugins(fesm5)[gzip]
devtools-plugin/fesm5/ngxs-devtools-plugin.js
 2.83KB +1%
✅ Plugins(fesm2015)[gzip]
form-plugin/fesm2015/ngxs-form-plugin.js
 2.74KB +1%
✅ Plugins(fesm2015)[gzip]
devtools-plugin/fesm2015/ngxs-devtools-plugin
.js
 2.65KB +1%
✅ Plugins(fesm5)[gzip]
logger-plugin/fesm5/ngxs-logger-plugin.js
 2.48KB +1%
✅ Plugins(umd.min)[gzip]
router-plugin/bundles/ngxs-router-plugin.umd.
min.js
 2.48KB +1%
✅ Plugins(umd.min)[gzip]
form-plugin/bundles/ngxs-form-plugin.umd.min.
js
 2.43KB +1%
✅ Plugins(fesm2015)[gzip]
logger-plugin/fesm2015/ngxs-logger-plugin.js
 2.37KB +1%
✅ Plugins(umd.min)[gzip]
storage-plugin/bundles/ngxs-storage-plugin.um
d.min.js
 2.32KB +1%
✅ Plugins(umd.min)[gzip]
websocket-plugin/bundles/ngxs-websocket-plugi
n.umd.min.js
 2.18KB +1%
✅ Plugins(umd.min)[gzip]
logger-plugin/bundles/ngxs-logger-plugin.umd.
min.js
 1.95KB +1%
✅ Plugins(umd.min)[gzip]
devtools-plugin/bundles/ngxs-devtools-plugin.
umd.min.js
 1.86KB +1%

No change in files bundle size

Unchanged groups (6)
Status Path Size Limits
✅ All Plugins(esm5)[gzip]
./-plugin/esm5/**/.js
 117.87KB +1%
✅ All Plugins(esm2015)[gzip]
./-plugin/esm2015/**/.js
 112.62KB +1%
✅ All Plugins(umd)[gzip]
./-plugin/bundles/.umd.js
 45.94KB +1%
✅ All Plugins(fesm5)[gzip]
./-plugin/fesm5/.js
 22.63KB +1%
✅ All Plugins(fesm2015)[gzip]
./-plugin/fesm2015/.js
 20.69KB +1%
✅ All Plugins(umd.min)[gzip]
./-plugin/bundles/.umd.min.js
 16.32KB +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon

bundlemon Bot commented Oct 16, 2022 •
edited
Loading

Copy link
Copy Markdown

BundleMon (Integration Projects)

Files updated (4)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng12-ivy/dist-integration/main.(h
ash).js
 67.49KB (+30B +0.04%) +1%
✅ Main bundles(Gzip)
hello-world-ng14-ivy/dist-integration/main.(h
ash).js
 65.1KB (+29B +0.04%) +1%
✅ Main bundles(Gzip)
hello-world-ng13-ivy/dist-integration/main.(h
ash).js
 69.42KB (+27B +0.04%) +1%
✅ Main bundles(Gzip)
hello-world-ng11-ivy/dist-integration/main.(h
ash).js
 70.77KB (+26B +0.04%) +1%

Total files change +112B +0.04%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@arturovt arturovt added this to the v3.7.6 milestone Oct 17, 2022
@markwhitfeld
markwhitfeld merged commit f744ab5 into master Oct 17, 2022
@markwhitfeld
markwhitfeld deleted the fix/1921 branch October 17, 2022 19:49
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Nov 29, 2022
Calciumdibromid Bot cabr2-bot Epsilon_02
Update ngxs-store monorepo to v3.7.6 (#1659)
55fff1f 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@ngxs/form-plugin](https://github.com/ngxs/store) | dependencies | patch | [`3.7.5` -> `3.7.6`](https://renovatebot.com/diffs/npm/@ngxs%2fform-plugin/3.7.5/3.7.6) |
| [@ngxs/storage-plugin](https://github.com/ngxs/store) | dependencies | patch | [`3.7.5` -> `3.7.6`](https://renovatebot.com/diffs/npm/@ngxs%2fstorage-plugin/3.7.5/3.7.6) |
| [@ngxs/store](https://github.com/ngxs/store) | dependencies | patch | [`3.7.5` -> `3.7.6`](https://renovatebot.com/diffs/npm/@ngxs%2fstore/3.7.5/3.7.6) |

---

### Release Notes

<details>
<summary>ngxs/store</summary>

### [`v3.7.6`](https://github.com/ngxs/store/blob/HEAD/CHANGELOG.md#&#8203;376-2022-11-23)

[Compare Source](ngxs/store@v3.7.5...v3.7.6)

-   Performance: Run change detection once for all `Actions` subscribers once the stream emits [#&#8203;1939](ngxs/store#1939)
-   Fix: Use `isObservable` to test whether actions return an observable [#&#8203;1925](ngxs/store#1925)
-   Fix: Call `ngxsOnChanges` whenever state changes (even through plugins) [#&#8203;1926](ngxs/store#1926)
-   Fix: Do not delegate errors to `ErrorHandler` if users catch them manually [#&#8203;1927](ngxs/store#1927)
-   Fix: Complete `Actions` stream once root view is removed [#&#8203;1933](ngxs/store#1933)
-   Fix: Storage Plugin - Do not skip deserialization for keys with dot notation [#&#8203;1924](ngxs/store#1924)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC40MC4wIiwidXBkYXRlZEluVmVyIjoiMzQuNDAuMiJ9-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1659
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markwhitfeld markwhitfeld markwhitfeld approved these changes
@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner
@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner
@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner
@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner
@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.7.6

Development

Successfully merging this pull request may close these issues.

2 participants

@arturovt @markwhitfeld