Skip to content

build: run SSR tests with cypress - #1281

Merged
markwhitfeld merged 7 commits into
masterfrom
build/cypress-ssr
Oct 2, 2019
Merged

build: run SSR tests with cypress#1281
markwhitfeld merged 7 commits into
masterfrom
build/cypress-ssr

Conversation

@arturovt

@arturovt arturovt commented Aug 26, 2019

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@markwhitfeld @splincode

What does this PR introduce?

  • SSR tests are running with cypress as they have to be.
  • Removed unnecessary packages, less packages = faster installation on the CI
  • Removed @nguniversal/express-engine as it's just not needed.
  • server.ts code became cleaner and much less than with @nguniversal/express-engine.
  • Since now SSR tests can be run in the interactive GUI and such way is much easier to debug and watch what's wrong etc.
  • That code ORIGIN_URL was just copied from some example and it is not used.

@splincode

Copy link
Copy Markdown
Member

@arturovt, please fix conflicts

# Conflicts:
#	package.json
#	yarn.lock
@markwhitfeld
markwhitfeld merged commit 5898acd into master Oct 2, 2019
@markwhitfeld
markwhitfeld deleted the build/cypress-ssr branch October 2, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants