feat: add jest-builders - #1068
Merged
Merged
Conversation
splincode
requested review from
arturovt and
markwhitfeld
and removed request for
markwhitfeld
May 18, 2019 17:08
arturovt
approved these changes
May 19, 2019
arturovt
left a comment
arturovt
left a comment
Member
There was a problem hiding this comment.
LGTM
Just add cacheDirectory as we discussed 馃帀
# Conflicts: # package.json # yarn.lock
Member
Author
|
@arturovt done |
markwhitfeld
approved these changes
May 20, 2019
Member
|
@splincode are there any docs updates needed? |
Member
Author
|
@markwhitfeld not need it |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Use Jest instead Karma
Does this PR introduce a breaking change?