[Help wanted] Add download button in actions menu

[fflorent]

The need

As a user, when I preview a file, I would like to download it easily with few clicks.

Rationales

If a file is easily downloadable from the files action popup:

a user not used to Nextcloud may click on a file in order to download it and wouldn't discover this menu.

Hopefully there is an action menu in the top-right corner and I propose to add a download button there:

Technical considerations

I just add a button… Still it opens few questions to me :) :

• my mother tongue is French, do you expect me to add a translation for this button or are there other localization tools for that?
• I saw there is the OCA.Files.Files.handleDownload method, but it requires a callback I don't need. Also I am not sure of its benefits here compared to a simple location.href = '…' for this case. Seems like it cookies are used, it's for knowing when the download starts.
• I could not make cypress run, but it seems it is already broken in the CI, I may attempt a fix later although I will need a bit of time :)
• Still I am not sure how to test my code with cypress: will there be a download dialog? And how to test the content of the downloaded file with cypress?

Cheers!

[skjnldsv]

Getting close.
Still a few comments :)

[skjnldsv]

This should be an ActionLink

[skjnldsv]

More suitable: getDavPath

Suggested change

	function genDavPath(fileInfo) {
	function getDavPath(fileInfo) {

[skjnldsv]

Also, please keep the same function declaration format

Suggested change

	function genDavPath(fileInfo) {
	const getDavPath = function(fileInfo) {

[skjnldsv]

Hey @fflorent, do you have any news? Do you need anything? :)
Feel free to ask! 🚀

[ChildLearningClub]

One click download button would be ideal I believe. On mobile even gallery view is to small to really see the photo well and with many photos a two click action menu might be cumbersome... As illustrated:
nextcloud/spreed#4614 (comment)
Or similarly Unsplash implementation would be the best option. I personally would even put it in place of the play button which I would only use if creating a digital picture frame.

I don’t know what it would take to implement on mobile, but swipe gestures would be really great. swipe down to download to mobile device, swipe up to save it to your Nextcloud or go to where you have it saved.

If I could code I would even add customizable swipe to make the whole planet happy.

[beardhatcode]

I addressed the comments in #814

[skjnldsv]

See #814