Revert "Fix url escaping"#395
Merged
Merged
Conversation
juliusknorr
requested review from
ChristophWurst,
gary-kim,
rullzer and
skjnldsv
This reverts commit edbf769. Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
revert/357
branch
from
03dd50f to
0208dd5
Compare
gary-kim
approved these changes
Feb 11, 2020
| * @param {String} path the full path | ||
| * @returns {string} url encoded file path | ||
| */ | ||
| const encodeFilePath = function(path) { |
Member
There was a problem hiding this comment.
Don't think this is necessary to add back in but we can just do that in another PR :).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit edbf769.
As discussed in #393 (comment)