[local] fix: image load error with number folder#2736
Closed
artonge wants to merge 3 commits into
Closed
Conversation
Signed-off-by: Franziska Bath <franziska.bath@strato.de>
Contributor
Author
|
/compile amend / |
nextcloud-command
force-pushed
the
artonge/local/2735
branch
from
fe18d22 to
b6e7c98
Compare
artonge
force-pushed
the
artonge/local/2735
branch
from
baddd21 to
3aa34fa
Compare
artonge
requested review from
skjnldsv and
susnux
and removed request for
skjnldsv
susnux
reviewed
Feb 11, 2025
Comment on lines
+100
to
+101
| ? fileInfo1[key].toString()?.localeCompare(fileInfo2[key].toString(), getLanguage(), { numeric: true }) | ||
| : -fileInfo1[key].toString()?.localeCompare(fileInfo2[key].toString(), getLanguage(), { numeric: true }) |
Contributor
There was a problem hiding this comment.
Not sure if -undefined makes sense. This is guaranteed to always be a string.
Suggested change
| ? fileInfo1[key].toString()?.localeCompare(fileInfo2[key].toString(), getLanguage(), { numeric: true }) | |
| : -fileInfo1[key].toString()?.localeCompare(fileInfo2[key].toString(), getLanguage(), { numeric: true }) | |
| ? String(fileInfo1[key]).localeCompare(fileInfo2[key].toString(), getLanguage(), { numeric: true }) | |
| : -String(fileInfo1[key]).localeCompare(fileInfo2[key].toString(), getLanguage(), { numeric: true }) |
Contributor
Author
There was a problem hiding this comment.
From the original PR, it is to match nextcloud/photos#783, which makes sense to keep similar.
Signed-off-by: Franziska Bath <franziska.bath@strato.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/local/2735
branch
from
3aa34fa to
8c08f81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local version of #2735 for CI