fix: remove long-unused desktop option - #690
Merged
Merged
Conversation
blizzz
reviewed
Jan 13, 2023
blizzz
left a comment
blizzz
left a comment
Member
There was a problem hiding this comment.
Looks good. Additionally an upgrade repair step could be added to clean up and remove an existing general-use_saml_auth_for_desktop setting.
Member
|
@solracsf could you squash the commits? What do you think about the repair step? |
AndyScherzinger
force-pushed
the
remove-desktop
branch
from
May 9, 2024 15:24
1364bfc to
a887c93
Compare
- Remove desktop option - Remove handling code - Remove tests - Add repair step to remove possible config DB entry Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Member
|
squashed, rebased, adjusted and added the repair step |
Member
Author
|
Sorry, I've totally forgot this one 😿 |
- getAppValue() returns strings Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Member
No worries – thanks again for the pre-work :) |
blizzz
approved these changes
May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #675
Signed-off-by: Git'Fellow 12234510+solracsf@users.noreply.github.com