Skip to content

feat(cli)!: Export to final destination directly#402

Merged
come-nc merged 1 commit into
mainfrom
feat/cli-export-part
May 2, 2023
Merged

feat(cli)!: Export to final destination directly#402
come-nc merged 1 commit into
mainfrom
feat/cli-export-part

Conversation

@Pytal

@Pytal Pytal commented Apr 29, 2023

Copy link
Copy Markdown
Member

Export directly to a .part file in the final destination and rename on completion

<uid>_<timestamp>.zip.part<uid>_<timestamp>.zip

Previously the partial archive was created in a temp folder then moved on completion to the specified folder and we now get the date timestamp before starting the export instead of after

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added the 3. to review Waiting for reviews label Apr 29, 2023
@Pytal Pytal added this to the 4.0 milestone Apr 29, 2023
@Pytal Pytal requested a review from come-nc April 29, 2023 02:48
@Pytal Pytal self-assigned this Apr 29, 2023
@come-nc come-nc merged commit 3aa23ab into main May 2, 2023
@come-nc come-nc deleted the feat/cli-export-part branch May 2, 2023 08:23
Comment thread lib/Command/Export.php
IUserManager $userManager,
UserMigrationService $migrationService,
ITempManager $tempManager
private IUserManager $userManager,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: This PHP 8.0+ syntax will not work with PHP7.4, which is the oldest version supported with NC 25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants