feat(download): allow to download archives from several URLs#637
Merged
Conversation
Altahrim
force-pushed
the
feat/allow_several_downloads_urls
branch
2 times, most recently
from
July 8, 2025 10:09
55e9a69 to
8ae7d3a
Compare
come-nc
reviewed
Jul 8, 2025
come-nc
left a comment
come-nc
left a comment
Collaborator
There was a problem hiding this comment.
I did not test but code looks good.
Can you add a comment for the regex?
| * Check if PHP is able to decompress archive format | ||
| */ | ||
| private function isAbleToDecompress(string $ext): bool { | ||
| // Only zip is supported for now |
Collaborator
There was a problem hiding this comment.
🤔 Smells like over-engineering, but ok.
Collaborator
Author
There was a problem hiding this comment.
At first, I wanted to support decompression for bz2 too, but it's not as straightforward as ZIP so I dropped it.
There is also another issue because we only have the signature for ZIP files.
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
feat/allow_several_downloads_urls
branch
from
July 8, 2025 12:25
8ae7d3a to
b8d50f6
Compare
Altahrim
marked this pull request as ready for review
July 8, 2025 12:38
skjnldsv
approved these changes
Jul 9, 2025
Collaborator
Author
|
/backport to stable31 |
2 tasks
Collaborator
Author
|
/backport to stable30 |
2 tasks
| } | ||
|
|
||
|
|
||
| use CurlHandle; |
Member
There was a problem hiding this comment.
I believe this is unnecessary. Saw a report on the forum:
Warning: The use statement with non-compound name ‘CurlHandle’ has no effect in [...]/updater/index.php on line 30
Maybe \CurlHandle on the type hint for getCurl() too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See nextcloud-releases/updater_server#1225