Fix: show Assistant icon if only translation provider available#8753
Conversation
janepie
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
|
/compile |
no compile in text needed – assets are automatically build after merge |
| priority: 7, | ||
| } | ||
| const hasAssistantTaskTypes = loadState('text', 'taskprocessing', []).length > 0 | ||
| const hasAssistantTaskTypes = loadState('text', 'taskprocessing', []).length > 0 || loadState('text', 'translation_available', false) |
There was a problem hiding this comment.
is this complete? My gut feeling says, the next other thing that is neither taskprocessing nor translation will potentially end up in the same state?
There was a problem hiding this comment.
Well that's a problem of the hardcoded task type list in https://github.com/nextcloud/text/blob/678b78d451c5557269998e01d42c9b98d7e949d6/lib/Service/InitialStateProvider.php
I actually didn't check if we have new ones that are not in there. Maybe it would be nicer to filter for task types that have Text as input? But that would be a bigger change, not for tonight :D
Oh good to know! |
What is |
1 min :) |
janepie
force-pushed
the
fix/assistant-icon-on-translate
branch
from
231270c to
2dc9698
Compare
Signed-off-by: janepie <49834966+janepie@users.noreply.github.com> Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
janepie
force-pushed
the
fix/assistant-icon-on-translate
branch
from
2dc9698 to
80ee77e
Compare
|
/backport to stable34 |
|
/backport to stable33 |
|
Playwright tests are breaking everywhere and should be unrelated |
2 participants
No description provided.