Techdebt/noid/node14 npm7 by marcoambrosini · Pull Request #5773 · nextcloud/spreed

marcoambrosini · 2021-06-14T15:04:52Z

ref nextcloud/app-tutorial#319 (comment)

PVince81 · 2021-06-15T08:25:03Z

@nickvergessen thanks for the suggestions. I already changed this in parallel, strange that Github doesn't say anything about this.

Now the errors are about actual code to adjust to satisfy eslint

PVince81 · 2021-06-15T08:26:37Z

@marcoambrosini the jest stuff is fixed as you asked, do you want to take care of the reported eslint issues ?

marcoambrosini · 2021-06-15T08:28:07Z

@marcoambrosini the jest stuff is fixed as you asked, do you want to take care of the reported eslint issues ?

Thanks @PVince81, yes I will!

nickvergessen · 2021-06-15T08:28:31Z

do you want to take care of the reported eslint issues ?

We talked about it with skjnldsv yesterday and it might also be okay to add a temporary exception to the eslint as it's just a different prefered coding style

skjnldsv · 2021-06-15T08:30:18Z

We talked about it with skjnldsv yesterday and it might also be okay to add a temporary exception to the eslint as it's just a different prefered coding style

Yes, requires investigation though, this is an error, not a warning 😁

marcoambrosini · 2021-06-15T08:34:53Z

Yes, requires investigation though, this is an error, not a warning 😁

Should be a super easy fix, on it

marcoambrosini · 2021-06-16T07:25:15Z

Ok it should™ all be good now, reviews plz!

nickvergessen

Seems to break calls completely

can't see my own video
sharing the screen doesn't work anymore

 [Vue warn]: Error in callback for watcher "localMediaModel.attributes.localStream": "TypeError: adapter.browserDetails is undefined"

found in

---> <LocalVideo> at src/components/CallView/shared/LocalVideo.vue
       <Grid> at src/components/CallView/Grid/Grid.vue
         <CallView> at src/components/CallView/CallView.vue
           <MainView> at src/views/MainView.vue
             <AppContent>
               <Content>
                 <App> at src/App.vue
                   <Root> vue.runtime.esm.js:619

TypeError: adapter.browserDetails is undefined
    exports attachmediastream.js:41
    _setLocalStream LocalVideo.vue:261
    localStream LocalVideo.vue:203
    VueJS 5

This reverts commit 5b75002.

This reverts commit 35be040.

This reverts commit e43077f.

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen · 2021-06-17T15:00:06Z

Tested with:

Edge
Safari
Firefox
Chromium

nickvergessen · 2021-06-21T13:29:00Z

+
+		// Toggles videos on and off
+		handleToggleVideo({ peerId, value }) {
+			this.sharedDatas[peerId].videoEnabled = value


marcoambrosini added 2. developing technical debt dependencies Pull requests that update a dependency file labels Jun 14, 2021

marcoambrosini added this to the 💖 Next Major (23) milestone Jun 14, 2021

marcoambrosini requested review from PVince81, danxuliu, nickvergessen and skjnldsv June 14, 2021 15:04

marcoambrosini self-assigned this Jun 14, 2021

skjnldsv reviewed Jun 15, 2021

View reviewed changes

Comment thread package.json

PVince81 reviewed Jun 15, 2021

View reviewed changes

Comment thread package.json

PVince81 reviewed Jun 15, 2021

View reviewed changes

Comment thread package.json

raimund-schluessler mentioned this pull request Jun 15, 2021

Bump deps and use npm7 nextcloud/app-tutorial#319

Merged

61 tasks

nickvergessen reviewed Jun 15, 2021

View reviewed changes

Comment thread .github/workflows/lint.yml Outdated

nickvergessen reviewed Jun 15, 2021

View reviewed changes

Comment thread .github/workflows/lint.yml Outdated

nickvergessen reviewed Jun 15, 2021

View reviewed changes

Comment thread .github/workflows/lint.yml Outdated

skjnldsv reviewed Jun 15, 2021

View reviewed changes

Comment thread src/components/CallView/Grid/Grid.vue

skjnldsv reviewed Jun 15, 2021

View reviewed changes

Comment thread src/components/CallView/CallView.vue Outdated

marcoambrosini requested review from PVince81, nickvergessen and skjnldsv June 16, 2021 07:24

marcoambrosini force-pushed the techdebt/noid/node14-npm7 branch from c26e11d to b3978a4 Compare June 16, 2021 07:25

nickvergessen reviewed Jun 16, 2021

View reviewed changes

Comment thread package.json Outdated

marcoambrosini force-pushed the techdebt/noid/node14-npm7 branch from b3978a4 to aa22cdb Compare June 16, 2021 08:28

nickvergessen reviewed Jun 16, 2021

View reviewed changes

Comment thread package.json

skjnldsv approved these changes Jun 16, 2021

View reviewed changes

marcoambrosini force-pushed the techdebt/noid/node14-npm7 branch from aa22cdb to 0dc7284 Compare June 16, 2021 15:04

nickvergessen requested changes Jun 17, 2021

View reviewed changes

marcoambrosini force-pushed the techdebt/noid/node14-npm7 branch from 0dc7284 to 29f4e1a Compare June 17, 2021 14:41

nickvergessen and others added 14 commits June 17, 2021 16:47

Revert "Bump webpack-merge from 5.7.3 to 5.8.0"

1129c0e

This reverts commit 5b75002.

Revert "Bump @babel/preset-env from 7.14.4 to 7.14.5"

d6460d1

This reverts commit 35be040.

Revert "Bump @babel/core from 7.14.3 to 7.14.5"

6b452be

This reverts commit e43077f.

Bump dependencies and use npm7

29b2dd5

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>

Lint fix

2f2b6b9

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>

Adjust jest workflow with node 14 + npm 7

1915022

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Adjust eslint + stylelint node and npm versions

ef81aec

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Update .github/workflows/lint.yml

f0764af

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>

Update .github/workflows/lint.yml

3e4d848

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>

Update .github/workflows/lint.yml

a3add6a

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>

Fix hasOwnProperty

2bba6b4

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>

bump node and npm engines

261a2b3

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>

Use eventbus to enable and disable videos

a575b86

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>

Add exception for matterbridge integration code

da3d3e3

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>

nickvergessen force-pushed the techdebt/noid/node14-npm7 branch from 29f4e1a to da3d3e3 Compare June 17, 2021 14:48

Fix call errors

83c7c0f

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen approved these changes Jun 17, 2021

View reviewed changes

nickvergessen added 4. to release and removed 2. developing labels Jun 17, 2021

marcoambrosini merged commit 86a5fbf into master Jun 17, 2021

marcoambrosini deleted the techdebt/noid/node14-npm7 branch June 17, 2021 15:18

nickvergessen mentioned this pull request Jun 21, 2021

Disable video doesn't work anymore #5817

Closed

nickvergessen reviewed Jun 21, 2021

View reviewed changes

Uh oh!

Conversation

marcoambrosini commented Jun 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PVince81 commented Jun 15, 2021

Uh oh!

PVince81 commented Jun 15, 2021

Uh oh!

marcoambrosini commented Jun 15, 2021

Uh oh!

nickvergessen commented Jun 15, 2021

Uh oh!

skjnldsv commented Jun 15, 2021

Uh oh!

marcoambrosini commented Jun 15, 2021

Uh oh!

Uh oh!

Uh oh!

marcoambrosini commented Jun 16, 2021

Uh oh!

Uh oh!

Uh oh!

nickvergessen left a comment

Choose a reason for hiding this comment

Uh oh!

nickvergessen commented Jun 17, 2021

Uh oh!

nickvergessen Jun 21, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

marcoambrosini commented Jun 14, 2021 •

edited

Loading