Skip to content

refactor: use SnowflakeAwareEntity#16595

Merged
nickvergessen merged 3 commits into
mainfrom
refactor/use-snowflakeawareentity
Jan 7, 2026
Merged

refactor: use SnowflakeAwareEntity#16595
nickvergessen merged 3 commits into
mainfrom
refactor/use-snowflakeawareentity

Conversation

@miaulalala

@miaulalala miaulalala commented Dec 18, 2025 •
edited by nickvergessen
Loading

Copy link
Copy Markdown
Contributor

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@miaulalala miaulalala self-assigned this Dec 18, 2025
@miaulalala
miaulalala force-pushed the refactor/use-snowflakeawareentity branch from 7a7c297 to da021c2 Compare December 18, 2025 22:42
@nickvergessen
nickvergessen self-requested a review December 19, 2025 09:34
@nickvergessen nickvergessen added this to the 🍏 Next Major (33) milestone Dec 19, 2025
@nickvergessen nickvergessen added feature: api 🛠️ OCS API for conversations, chats and participants technical debt feature: chat 💬 Chat and system messages and removed standardisation labels Dec 19, 2025
@SystemKeeper

SystemKeeper commented Dec 21, 2025

Copy link
Copy Markdown
Contributor

So the generator in the mapper can also be removed ?

@CarlSchwan
CarlSchwan force-pushed the refactor/use-snowflakeawareentity branch from da021c2 to 8333b53 Compare January 7, 2026 12:35
@CarlSchwan CarlSchwan mentioned this pull request Jan 7, 2026
Closed
4 tasks
@CarlSchwan
CarlSchwan marked this pull request as ready for review January 7, 2026 12:36
@CarlSchwan
CarlSchwan force-pushed the refactor/use-snowflakeawareentity branch from 8333b53 to bd34ab8 Compare January 7, 2026 12:43
@nickvergessen
nickvergessen force-pushed the refactor/use-snowflakeawareentity branch from bd34ab8 to f077ca8 Compare January 7, 2026 12:44
@nickvergessen

nickvergessen commented Jan 7, 2026

Copy link
Copy Markdown
Member

Internal Server Error\nAn exception occurred while executing a query: SQLSTATE[HY000]: General error: 1364 Field 'id' doesn't have a default value

Something seems off in the update case

@nickvergessen

nickvergessen commented Jan 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Internal Server Error\nOC\Snowflake\SnowflakeDecoder::decode(): Argument #1 ($snowflakeId) must be of type string, int given, called in …/lib/public/AppFramework/Db/SnowflakeAwareEntity.php on line 53 in file '…/lib/private/Snowflake/SnowflakeDecoder.php' line 26

Reading also fails.

Will have a look

This was referenced Jan 7, 2026
Merged
Merged
miaulalala and others added 2 commits January 7, 2026 17:20
@miaulalala @nickvergessen
fix(scheduled): use SnowflakeAwareEntity
5809ea4 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@nextcloud-command @nickvergessen
chore(dev-deps): Bump nextcloud/ocp package
351cb36 
Signed-off-by: GitHub <noreply@github.com>
@nickvergessen
nickvergessen force-pushed the refactor/use-snowflakeawareentity branch from 29170a0 to 351cb36 Compare January 7, 2026 16:20
@nickvergessen
fix(scheduled): Remove createdAt column which is conflicting with sno…
bd04c12 
…wflake entity

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

nickvergessen commented Jan 7, 2026

Copy link
Copy Markdown
Member

Had to drop the createdAt column now as it is overlayed with the getCreatedAt from snowflake entity which also returned a different data type.

@nickvergessen
nickvergessen merged commit 234b0af into main Jan 7, 2026
82 checks passed
@nickvergessen
nickvergessen deleted the refactor/use-snowflakeawareentity branch January 7, 2026 16:53
@nickvergessen nickvergessen mentioned this pull request Jan 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes
@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@miaulalala miaulalala

Labels

feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages technical debt

Projects

None yet

Milestone

v23.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

5 participants

@miaulalala @SystemKeeper @nickvergessen @CarlSchwan @nextcloud-command