Use a parameterized translation for CPU thread count#1032
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add parameters like thread count as variable for i18n
fix(i18n): use parameterized string for CPU name and thread count
Jun 22, 2026
Copilot
AI
changed the title
fix(i18n): use parameterized string for CPU name and thread count
Use a parameterized translation for CPU thread count
Jun 23, 2026
…able string The CPU row in settings-admin.php previously used a standalone translated "threads" word with the count concatenated outside the string, which doesn't work properly for RTL languages or languages with different word order. Now uses a single translatable string '%1$s (%2$d threads)' with the CPU name as %1$s and thread count as %2$d, allowing translators to reorder components as needed. Assisted-by: GitHub Copilot (claude-sonnet-4.6) Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
copilot/nextcloud-1022-i18n-include-parameters
branch
from
e03683b to
5cba1a7
Compare
Collaborator
|
/backport to stable34 |
kesselb
approved these changes
Jul 8, 2026
Collaborator
|
/backport to stable33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CPU row in the admin settings rendered the thread count by concatenating a translated label with a raw numeric value. That prevents translators from reordering the phrase correctly for RTL and other locale-specific sentence structures.
i18n
threadslabel with a single translatable string using positional parametersLocalization assets
l10n/files unchanged; the source string change is limited to the template and can be picked up by the normal translation pipeline