Apply password policy on user creation

[michag86]

Fix for #538

[mention-bot]

@michag86, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen, @icewind1991 and @MorrisJobke to be potential reviewers

[MorrisJobke]

Tested and works 👍

[MorrisJobke]

cc @schiessle @rullzer @nickvergessen

[nickvergessen]

integration tests fail

[MorrisJobke]

--- Failed scenarios:

    /drone/src/github.com/nextcloud/server/build/integration/features/sharing-v1.feature:907

  Scenario: Merging shares for recipient when shared from outside with user then group and recipient renames in between                                # /drone/src/github.com/nextcloud/server/build/integration/features/sharing-v1.feature:907
    Given As an "admin"                                                                                                                                # FeatureContext::asAn()
[Wed Aug  3 10:46:14 2016] ::1:52424 [404]: /ocs/v2.php/cloud/users/user0
[Wed Aug  3 10:46:14 2016] ::1:52425 [200]: /ocs/v1.php/cloud/users
[Wed Aug  3 10:46:15 2016] ::1:52426 [200]: /ocs/v1.php/cloud/users/user0
[Wed Aug  3 10:46:15 2016] ::1:52427 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                                                                            # FeatureContext::assureUserExists()
[Wed Aug  3 10:46:15 2016] ::1:52428 [404]: /ocs/v2.php/cloud/users/user1
[Wed Aug  3 10:46:15 2016] ::1:52429 [200]: /ocs/v1.php/cloud/users
[Wed Aug  3 10:46:16 2016] ::1:52430 [200]: /ocs/v1.php/cloud/users/user1
[Wed Aug  3 10:46:16 2016] ::1:52431 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                                                                            # FeatureContext::assureUserExists()
[Wed Aug  3 10:46:16 2016] ::1:52432 [404]: /ocs/v2.php/cloud/groups/group1
[Wed Aug  3 10:46:17 2016] ::1:52433 [200]: /ocs/v1.php/cloud/groups
[Wed Aug  3 10:46:17 2016] ::1:52434 [200]: /ocs/v2.php/cloud/groups/group1
    And group "group1" exists                                                                                                                          # FeatureContext::assureGroupExists()
[Wed Aug  3 10:46:17 2016] ::1:52435 [200]: /ocs/v2.php/cloud/users/user1/groups
[Wed Aug  3 10:46:17 2016] ::1:52436 [200]: /ocs/v1.php/cloud/users/user1/groups
[Wed Aug  3 10:46:17 2016] ::1:52437 [200]: /ocs/v2.php/cloud/users/user1/groups
    And user "user1" belongs to group "group1"                                                                                                         # FeatureContext::assureUserBelongsToGroup()
[Wed Aug  3 10:46:17 2016] ::1:52438 [201]: /remote.php/webdav/merge-test-outside-groups-renamebeforesecondshare
    And user "user0" created a folder "merge-test-outside-groups-renamebeforesecondshare"                                                              # FeatureContext::userCreatedAFolder()
[Wed Aug  3 10:46:18 2016] ::1:52439 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares?path=merge-test-outside-groups-renamebeforesecondshare
[Wed Aug  3 10:46:18 2016] ::1:52440 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
[Wed Aug  3 10:46:18 2016] ::1:52441 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares?path=merge-test-outside-groups-renamebeforesecondshare
    When folder "merge-test-outside-groups-renamebeforesecondshare" of user "user0" is shared with user "user1"                                        # FeatureContext::assureFileIsShared()
[Wed Aug  3 10:46:18 2016] ::1:52442 [201]: /remote.php/webdav/merge-test-outside-groups-renamebeforesecondshare
    And User "user1" moved folder "/merge-test-outside-groups-renamebeforesecondshare" to "/merge-test-outside-groups-renamebeforesecondshare-renamed" # FeatureContext::userMovedFile()
[Wed Aug  3 10:46:18 2016] ::1:52443 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares?path=merge-test-outside-groups-renamebeforesecondshare
[Wed Aug  3 10:46:18 2016] ::1:52444 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
[Wed Aug  3 10:46:19 2016] ::1:52445 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares?path=merge-test-outside-groups-renamebeforesecondshare
    And folder "merge-test-outside-groups-renamebeforesecondshare" of user "user0" is shared with group "group1"                                       # FeatureContext::assureFileIsSharedWithGroup()
[Wed Aug  3 10:46:19 2016] ::1:52446 [401]: /remote.php/webdav/merge-test-outside-groups-renamebeforesecondshare-renamed
[Wed Aug  3 10:46:19 2016] ::1:52447 [404]: /remote.php/webdav/merge-test-outside-groups-renamebeforesecondshare-renamed
    Then as "user1" gets properties of folder "merge-test-outside-groups-renamebeforesecondshare-renamed" with                                         # FeatureContext::asGetsPropertiesOfFolderWith()
      | {http://owncloud.org/ns}permissions |
      HTTP error: 404 (Sabre\DAV\Exception)
    And the single response should contain a property "{http://owncloud.org/ns}permissions" with value "SRDNVCK"                                       # FeatureContext::theSingleResponseShouldContainAPropertyWithValue()
    And as "user1" the folder "merge-test-outside-groups-renamebeforesecondshare" does not exist                                                       # FeatureContext::asTheFileOrFolderDoesNotExist()

[michag86]

I do not understand how the error is related to my modification. 😔

[nickvergessen]

@rullzer is something broken thereon master?

[rullzer]

Yes will rebase when "fix" is in master

[schiessle]

tested, works! Thanks for your contribution!

[schiessle]

👍

[schiessle]

failing tests are unrelated

[nickvergessen]

Should backport this @schiessle ?