feat: Add support for NOT ILIKE in query builder expressions#61521
Open
Koc wants to merge 1 commit into
Open
Conversation
Koc
requested review from
Altahrim,
ArtificialOwl,
come-nc and
icewind1991
and removed request for
a team
CarlSchwan
approved these changes
Jun 23, 2026
Koc
force-pushed
the
feature/add-not-i-like-to-query-builder
branch
3 times, most recently
from
fd53198 to
0a7ac5d
Compare
Contributor
Author
|
@CarlSchwan I've applied changes but now psalm fails 😕 |
Koc
force-pushed
the
feature/add-not-i-like-to-query-builder
branch
2 times, most recently
from
392e3f4 to
727772c
Compare
Contributor
Author
|
Psalm fixed. Current test failures looks unrelated to my changes |
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/add-not-i-like-to-query-builder
branch
from
727772c to
29842d5
Compare
come-nc
reviewed
Jun 29, 2026
Comment on lines
+45
to
+47
| $x = $this->helper->quoteColumnName($x); | ||
| $y = $this->helper->quoteColumnName($y); | ||
| return $this->expressionBuilder->comparison($x, ' COLLATE ' . $this->collation . ' NOT LIKE', $y); |
Contributor
There was a problem hiding this comment.
This one is not ILIKE and has to lower() call either, is it the right implementation?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We already have
like, notLike, iLike. Let's add alsonotILiketo have full set of the operationsChecklist
3. to review, feature component)stable32)AI (if applicable)