-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
fix(theming): use IAppConfig for all ThemingDefaults #56039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
| /** | ||
| * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OCA\Theming; | ||
|
|
||
| use OCP\Config\Lexicon\Entry; | ||
| use OCP\Config\Lexicon\ILexicon; | ||
| use OCP\Config\Lexicon\Strictness; | ||
| use OCP\Config\ValueType; | ||
|
|
||
| /** | ||
| * Config Lexicon for theming. | ||
| * | ||
| * Please Add & Manage your Config Keys in that file and keep the Lexicon up to date! | ||
| * | ||
| * {@see ILexicon} | ||
| */ | ||
| class ConfigLexicon implements ILexicon { | ||
| /** The cache buster index */ | ||
| public const CACHE_BUSTER = 'cachebuster'; | ||
| public const USER_THEMING_DISABLED = 'disable-user-theming'; | ||
|
|
||
| /** Name of the software running on this instance (usually "Nextcloud") */ | ||
| public const PRODUCT_NAME = 'productName'; | ||
| /** Short name of this instance */ | ||
| public const INSTANCE_NAME = 'name'; | ||
| /** Slogan of this instance */ | ||
| public const INSTANCE_SLOGAN = 'slogan'; | ||
| /** Imprint URL of this instance */ | ||
| public const INSTANCE_IMPRINT_URL = 'imprintUrl'; | ||
| /** Privacy URL of this instance */ | ||
| public const INSTANCE_PRIVACY_URL = 'privacyUrl'; | ||
|
|
||
| // legacy theming | ||
| /** Base URL of this instance */ | ||
| public const BASE_URL = 'url'; | ||
| /** Base URL for documentation */ | ||
| public const DOC_BASE_URL = 'docBaseUrl'; | ||
|
|
||
| public function getStrictness(): Strictness { | ||
| return Strictness::NOTICE; | ||
| } | ||
|
|
||
| public function getAppConfigs(): array { | ||
| return [ | ||
| // internals | ||
| new Entry( | ||
| self::CACHE_BUSTER, | ||
| ValueType::INT, | ||
| defaultRaw: 0, | ||
| definition: 'The current cache buster key for theming assets.', | ||
| ), | ||
| new Entry( | ||
| self::USER_THEMING_DISABLED, | ||
| ValueType::BOOL, | ||
| defaultRaw: false, | ||
| definition: 'Whether user theming is disabled.', | ||
| ), | ||
|
|
||
| // instance theming | ||
| new Entry( | ||
| self::PRODUCT_NAME, | ||
| ValueType::STRING, | ||
| defaultRaw: 'Nextcloud', | ||
| definition: 'The name of the software running on this instance (usually "Nextcloud").', | ||
| ), | ||
| new Entry( | ||
| self::INSTANCE_NAME, | ||
| ValueType::STRING, | ||
| defaultRaw: '', | ||
| definition: 'Short name of this instance.', | ||
| ), | ||
| new Entry( | ||
| self::INSTANCE_SLOGAN, | ||
| ValueType::STRING, | ||
| defaultRaw: '', | ||
| definition: 'Slogan of this instance.', | ||
| ), | ||
| new Entry( | ||
| self::INSTANCE_IMPRINT_URL, | ||
| ValueType::STRING, | ||
| defaultRaw: '', | ||
| definition: 'Imprint URL of this instance.', | ||
| ), | ||
| new Entry( | ||
| self::INSTANCE_PRIVACY_URL, | ||
| ValueType::STRING, | ||
| defaultRaw: '', | ||
| definition: 'Privacy URL of this instance.', | ||
| ), | ||
|
|
||
| // legacy theming | ||
| new Entry( | ||
| self::BASE_URL, | ||
| ValueType::STRING, | ||
| defaultRaw: '', | ||
| definition: 'Base URL of this instance.', | ||
| ), | ||
| new Entry( | ||
| self::DOC_BASE_URL, | ||
| ValueType::STRING, | ||
| defaultRaw: '', | ||
| definition: 'Base URL for documentation.', | ||
| ), | ||
| ]; | ||
| } | ||
|
|
||
| public function getUserConfigs(): array { | ||
| return []; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈 #56626