Skip to content

Do not show full storage notification to users with 0 Bytes quota #43544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkhradil wants to merge 1 commit into from
Closed

Do not show full storage notification to users with 0 Bytes quota #43544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/files/src/components/NavigationQuota.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ export default {
},

mounted() {
// Warn the user if the available storage is 0 on page load
if (this.storageStats?.free <= 0) {
// Warn the user if the available storage is 0 on page load, except for users with 0 B quota
if (this.storageStats?.free <= 0 && this.storageStats?.quota != 0) {
Comment on lines +91 to +92

@joshtrichards joshtrichards Feb 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Warn the user if the available storage is 0 on page load, except for users with 0 B quota
if (this.storageStats?.free <= 0 && this.storageStats?.quota != 0) {
// Warn the user if the available storage is 0 on page load, except for users with 0 B or unlimited quota
if (this.storageStats?.free <= 0 && this.storageStats?.quota != 0 && this.storageStats?.quota != -3) {

I think something like the above can fix #43280 here too at the other end of the quota spectrum (an unlimited one).

When the quota is unlimited, quota should be -3 here e.g. SPACE_UNLIMITED via getStorageInfo() and getUserQuota() et al.

@susnux susnux Feb 18, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think this makes sense

@skjnldsv skjnldsv Feb 19, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then let's check for quota greater or equal to 0. That way we also ignore negative quotas

this.showStorageFullWarning()
}
},
Expand Down