Skip to content

[stable25] Fix theming tests#35415

Merged
PVince81 merged 1 commit into
stable25from
fix/35346/stable25
Nov 25, 2022
Merged

[stable25] Fix theming tests#35415
PVince81 merged 1 commit into
stable25from
fix/35346/stable25

Conversation

@Pytal

@Pytal Pytal commented Nov 25, 2022

Copy link
Copy Markdown
Member

Fix tests for #35346

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews feature: theming tests Related to tests labels Nov 25, 2022
@Pytal Pytal added this to the Nextcloud 25.0.2 milestone Nov 25, 2022
@Pytal Pytal self-assigned this Nov 25, 2022

@szaimen szaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, thanks!

@szaimen

szaimen commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

/backport to master

@Pytal

Pytal commented Nov 25, 2022

Copy link
Copy Markdown
Member Author

/backport to master

master is already passing though?

@szaimen

szaimen commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

master is already passing though?

yeah, I dont understant why...

@szaimen szaimen requested a review from a team November 25, 2022 07:52

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit e58cf22 into stable25 Nov 25, 2022
@PVince81 PVince81 deleted the fix/35346/stable25 branch November 25, 2022 07:58
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to master failed. Please do this backport manually.

@szaimen

szaimen commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

/backport to master

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to master failed. Please do this backport manually.

@blizzz blizzz mentioned this pull request Nov 25, 2022
1 task
@szaimen szaimen restored the fix/35346/stable25 branch November 25, 2022 08:23
@szaimen szaimen deleted the fix/35346/stable25 branch November 25, 2022 08:29
@szaimen

szaimen commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

Manual backport in #35420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: theming tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants