Accept multipe args on concat#30378
Merged
Merged
Conversation
vitormattos
marked this pull request as draft
December 22, 2021 17:40
vitormattos
marked this pull request as ready for review
December 22, 2021 17:59
Author
|
static tests fixed on #30370 |
vitormattos
force-pushed
the
feature/accept-multiple-args-on-concat
branch
from
December 23, 2021 10:18
1d59baf to
226105f
Compare
Author
|
Hi @ChristophWurst! Can you help to do a review? |
Member
|
The psalm error seems like a regression in composer: composer/composer#10387 |
vitormattos
force-pushed
the
feature/accept-multiple-args-on-concat
branch
2 times, most recently
from
December 28, 2021 13:46
6f4db93 to
74dfec2
Compare
vitormattos
force-pushed
the
feature/accept-multiple-args-on-concat
branch
from
December 28, 2021 15:23
74dfec2 to
b346f93
Compare
vitormattos
force-pushed
the
feature/accept-multiple-args-on-concat
branch
from
January 5, 2022 10:45
b346f93 to
f16a4ae
Compare
Member
Needs a rebase Also should have a unit test |
vitormattos
force-pushed
the
feature/accept-multiple-args-on-concat
branch
from
January 5, 2022 15:17
2404e42 to
7c6c0d4
Compare
vitormattos
force-pushed
the
feature/accept-multiple-args-on-concat
branch
2 times, most recently
from
January 5, 2022 15:39
6d3b5e5 to
411df0e
Compare
Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos
force-pushed
the
feature/accept-multiple-args-on-concat
branch
from
January 6, 2022 11:15
411df0e to
06b7e3d
Compare
vitormattos
force-pushed
the
feature/accept-multiple-args-on-concat
branch
4 times, most recently
from
January 6, 2022 19:14
5ae111b to
96273d3
Compare
Signed-off-by: Vitor Mattos <vitor@php.rio>
nickvergessen
force-pushed
the
feature/accept-multiple-args-on-concat
branch
from
January 7, 2022 08:54
96273d3 to
f732cf1
Compare
nickvergessen
approved these changes
Jan 7, 2022
nickvergessen
requested review from
a team and
PVince81
and removed request for
a team
January 7, 2022 08:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem: Abstraction of SQL
CONCATfunction only accept two arguments but the SQL function accept many.The solution: I used the php argument operator
...to make possible pass many arguments.Real example of usage on PR #30379 with tree arguments:
server/lib/private/Comments/Manager.php
Lines 1022 to 1026 in 3c23050