Enforce no notnull for boolean to store false

[nickvergessen]

Fails until #24053 is in

Fix #24083

[rullzer]

I get this is just how oracle works. But when you hae a boolean field that you can't store false is just somewhat insane.

[nickvergessen]

But when you have a boolean field that you can't store false is just somewhat insane.

Well oracle has no boolean fields, doctrine maps it to an integer with length 1 byte. "You" manually tell it to not allow 0/null, so that's what we do wrapped by doctrine.

[rullzer]

But when you have a boolean field that you can't store false is just somewhat insane.

Well oracle has no boolean fields, doctrine maps it to an integer with length 1 byte. "You" manually tell it to not allow 0/null, so that's what we do wrapped by doctrine.

That is somehow more confusing. If doctrine maps it takes an int. Null and 0 are not the same. So if you have a mandatory int field. You can't set it to 0?

[rullzer]

Conflicts. BUta lso CI is not happy

[nickvergessen]

Rebased, lets see what CI says

[juliusknorr]

Hm haven't seen those tests failing before so I'd assume that might be a related failure, but I cannot see how from the affected code: integration/sharing_features/sharing-v1-video-verification.feature I've retriggered drone once so let's see

[nickvergessen]

yeah, talk does not install anymore :(
I will make a PR

[nickvergessen]

Ref nextcloud/spreed#5445

[ChristophWurst]

this should definitely go into our upgrade docs

[nickvergessen]

Added to #26407 (comment)