Cleanup share by mail a bit#21692
Merged
Merged
Conversation
rullzer
added
3. to review
rullzer
requested review from
ChristophWurst,
MorrisJobke,
juliusknorr,
kesselb and
skjnldsv
Member
Author
|
/compile amend / |
Member
Author
|
CC: @tobiasKaminsky for the capabilities. Just check them before and after this PR. Now we have the info if the password is enforced for this share type. |
npmbuildbot-nextcloud
Bot
force-pushed
the
cleanup/sharebymail
branch
from
9dfaad8 to
85cc0c7
Compare
* Moved to ned IBootstrap * Register everything via the capabilities api (So clients can use it as well) - This applies to the enforcing passwords * Updated the sharing js code to use it * removed app.php * removed unused settings now * typehints * strict typing Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com> Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
cleanup/sharebymail
branch
from
85cc0c7 to
0bcc643
Compare
Member
|
I fixed the CS warnings 👍 |
4 tasks
MorrisJobke
added
4. to release
Member
|
Thanks for doing this! 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
well)
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl