Skip to content

Fix language multiselect action #20019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 1 commit into from
Mar 24, 2020
Merged

Fix language multiselect action #20019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions apps/settings/css/settings.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1455,10 +1455,21 @@ doesnotexist:-o-prefocus, .strengthify-wrapper {
.lastLogin {
min-width: $grid-col-min-width;

color: var(--color-text-dark);
vertical-align: baseline;
text-overflow: ellipsis;
overflow: hidden;
doesnotexist:-o-prefocus, .strengthify-wrapper {

@skjnldsv skjnldsv Mar 21, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this? 🤔 doesnotexist

@GretaD GretaD Mar 22, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPERA hack for strengthify ;)

@skjnldsv skjnldsv Mar 23, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, should/do we support opera? 🙈

@juliusknorr juliusknorr Mar 23, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GretaD Did you verify if that is still needed? As Opera is also chromium based nowadays.

@ChristophWurst ChristophWurst Mar 23, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, should/do we support opera? see_no_evil

Don’t remove browsers just because you don’t know them. Opera Mini has 100 million users in Africa and it is more popular in the global market than Microsoft Edge. Chinese QQ Browsers has more market share than Firefox and desktop Safari combined.

Source: https://github.com/browserslist/browserslist#best-practices

@GretaD GretaD Mar 23, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that we use it also somewhere else, and went with it. Im fine to remove it

@skjnldsv skjnldsv Mar 23, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to improve there anyway
https://github.com/nextcloud/browserslist-config/blob/master/browserlist.config.js

https://jamie.build/last-2-versions

@GretaD GretaD Mar 23, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im fixing a support ticket with this pr, should we merge it and then i can fix it also here: https://github.com/nextcloud/browserslist-config/blob/master/browserlist.config.js?

@GretaD GretaD Mar 23, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sooo, is it good to go? :D

color: var(--color-text-dark);
vertical-align: baseline;
text-overflow: ellipsis;
}
}
&:not(.row--editable) {
&.name,
&.password,
&.displayName,
&.mailAddress,
&.userBackend,
&.languages {
overflow: hidden;
}
}

.groups,
Expand Down