[Bug]: New user modal has unexpected and undesirable behavior

[privatemaker]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

Currently when adding a new user on NextCloud the modal which pops-up has some unexpected and undesirable UX behaviors.

Luckily all of which are easy to improve 😄

Steps to reproduce

1. As an admin navigate to Users section /settings/users
2. Click on + New user
3. Fill out user data
4. Trigger one of the three hide or cancel action s

5. At this stage the modal is hidden
6. Re-click + New user button
7. Observe all entered data is still present

Actions 1 and 2 can be accidental and if one is clumsy can happen often, especially given on lower resolution monitors the Add new user completion button is hidden off screen (see screenshot) and requires a scrolling action to locate. This introduces a sense of panic "Oh no. Where did the data I just entered go?"

Action 3 is more clearly intentional, but I argue that general user consensus expectation is that clicking an X would cancel a process and clear entered data. This does not happen.

Luckily, in all three states the data is still in the modal. Phew!!

Expected behavior

Some proposed improvements:

1. All three actions trigger a confirmation dialogue Do you mean to cancel adding this user and clear the data you entered?

2. Only clicking Action 3 (the X) triggers this dialogue and the other actions do nothing.

Alternatively, moving away from a Modal for the entire New user action to a full page view is another route to improving this, but obviously more engineering effort.

Installation method

None

Nextcloud Server version

master

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

SQlite

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

[pringelmann]

This was fixed by #59406

The new behavior matches your second proposal:

2. Only clicking Action 3 (the X) triggers this dialogue and the other actions do nothing.