Default phone region example faulty and config help incomplete

[wiswedel]

46b073d adds some functionality, samples and checks for default phone regions.

• The setup warning (https://github.com/nextcloud/server/blob/master/core/js/setupchecks.js#L221) doesn't tell where to apply the recommended setting (solution: in the config.php). The warning should also contain a link to a list of valid ISO 3166-1 codes: https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2#Officially_assigned_code_elements
• The config.sample.php (https://github.com/nextcloud/server/blob/master/config/config.sample.php#L205) contains an invalid region ("EN"). Suggestion: DE

CC @nickvergessen

[nickvergessen]

I picked GB, as DE is already mentioned in the doc block. Link also added in #24740

[geep33]

No info at all🧐

…

On Thu, Dec 17, 2020, 1:16 AM Joas Schilling ***@***.***> wrote: I picked GB, as DE is already mentioned in the doc block. Link also added in #24740 <#24740> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#24738 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARULPN7JORWNKSXCG7PGAJLSVG46HANCNFSM4U6YL3FQ> .

[wiswedel]

No info at all🧐

What do you mean? @geep33

[dnv]

I just upgraded from 20 to 21 via docker-compose and am getting a "Your installation has no default phone region set." warning. How/where do I even set it?

[wiswedel]

How/where do I even set it?

It goes to your config.php. There's a help section in the config.sample.php: https://github.com/nextcloud/server/blob/master/config/config.sample.php#L197-L205

[dnv]

Isn't config.php generated automatically from environment variables every time the container is brought up? I was under the impression editing it manually is pointless since any changes would be wiped out on restart.