feat: Allow to configure different policies per password context#717
Merged
Conversation
susnux
force-pushed
the
feat/support-password-context
branch
from
January 18, 2025 15:01
d87ea09 to
f3d9920
Compare
susnux
changed the title
juliusknorr
reviewed
Jan 20, 2025
juliusknorr
approved these changes
Jan 30, 2025
juliusknorr
left a comment
juliusknorr
left a comment
Member
There was a problem hiding this comment.
Nice, changes seem good and I also gave some smoke test 👍
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* Add support for multiple password policies (per context) * Split Vue files into components * Use Typescript (also for the script part of Vue files) Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/support-password-context
branch
from
January 30, 2025 14:43
f3d9920 to
0290c4f
Compare
Contributor
Author
|
/backport to stable31 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server already emits the events with password context information (new with Nextcloud 31), so this implements the support to configure different policies for different contexts.
For the reviewers: Please first check the backend stuff - if there is anything we need to adjust we should do this first before adjusting the frontend.
Summary
Possible improvement
Maybe it would be easier to make the server enum backed with the string value.
That would remove 2 functions here and make some functions easier.