Fix folder naming not using capabilities renamer#3566
Merged
Conversation
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
i2h3
approved these changes
Jul 2, 2025
Contributor
|
Please add instructions how to test, though. |
Collaborator
Author
Added |
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Collaborator
Author
|
@marinofaggiana did you test before merging? |
Member
|
@mpivchev haven't you tried it? (it seems like a simple function, doesn't it?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naming a folder A* where the "*" is not part of the forbidden characters coming from capabilities, would cause the folder to be named A instead.
Fixed by making the folder creating take into account forbidden characters from capabilities instead of generic forbidden characters.
Test creating a folder named A* without WCF ("*" allowed) (Christine account can be used) and check if folder is created successfully and files can be added.
Test a server with WCF enabled ("*" is not allowed) (internal instance can work) and check if you get an error during naming. "Save" button should be disabled.